List view should not assume default filter anymore #2234
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#2234
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Currently, when creating a list view, it assumes a default filter
done = false
. With the new views, this should not be applied unconditionally anymore, instead it should be the default when a new list view is created, but should be configurable by the user.In our case I'm creating a Kanban view with a filter like
done = false || (done = true && done_at > 'now-14d')
to show all tasks but limit the length of thedone
column, and then I'm adding another list view with the filterdone = true
to show all done tasks. When doing that, the default filterdone = false
directly contradicts the filter I have configured, showing no tasks at all unless the filter is cleared every time the view is opened.I'd propose to have the
done = false
filter applied by default when creating a new view (and part of the standard view), but basically move this to the view filter logic.Vikunja Version
unstable
Browser and version
No response
Can you reproduce the bug on the Vikunja demo site?
Yes
Screenshots
No response
I've been looking into the code and I'm not sure how to handle this. The view filter is applied in the backend, while the default filter
done=false
is applied in the frontend. It's easy to disable this default filter, but disabling it based on the condition that there's a view filter present is difficult, as this information is not available in the frontend.The only option I could envision right now is to:
This however could lead to another unwanted behaviour, if someone was using the new views already, created filtered list views already, relying on the fact that done tasks would be excluded. That might be a niche case though
Ahh yes, that makes a lot of sense!
To fix this, I would
done = false
filter when creating the default viewsSo basically what you said :)
I think the last point, people who are already using this would be a niche use case, especially since the features is not released yet. The goal should be to keep the default behaviour if uses didn't change anything, that means show only undone tasks in list view by default.