vikunja/vikunja
6
43
Fork 73
Code Issues 151 Pull Requests 16 Packages Releases 32 Activity

feat: assign users to teams via OIDC claims #1393

Merged
konrad merged 93 commits from viehlieb/api:950_reworked_assign_teams_via_oidc into main 2024-03-02 08:47:12 +00:00
Conversation 34 Commits 93 Files Changed 26 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9dd3317908 - Show all commits

2
pkg/models/team_members.go
View File

@ -111,7 +111,7 @@ func (tm *TeamMember) Delete(s *xorm.Session, _ web.Auth) (err error) {
func (tm *TeamMember) CheckMembership(s *xorm.Session) (exists bool, err error) {
exists, err = s.
Where("team_id = ? AND user_id = ?", tm.TeamID, tm.UserID).
viehlieb marked this conversation as resolved Outdated
konrad commented 2023-02-13 10:18:22 +00:00
Outdated
Review
Copy Link

Can you do this either with a join to avoid loading the user or at least use the "simple" function?

Can you do this either with a join to avoid loading the user or at least use the "simple" function?
viehlieb commented 2023-02-13 17:49:47 +00:00
Outdated
Review
Copy Link

done.

done.
Get(&TeamMember{})
Exist(&TeamMember{})
viehlieb marked this conversation as resolved Outdated
konrad commented 2023-02-14 11:37:43 +00:00
Outdated
Review
Copy Link

This should be Exist(&TeamMember{}).

This should be `Exist(&TeamMember{})`.
viehlieb commented 2023-02-23 14:48:53 +00:00
Outdated
Review
Copy Link

done

done
return exists, err
}