pkg/models/error.go

@@ -875,6 +875,33 @@ func (err ErrUserAlreadyAssigned) HTTPError() web.HTTPError {
 	}
 }
 
+// ErrReminderRelativeToMissing represents an error where a task has a relative reminder without reference date
+type ErrReminderRelativeToMissing struct {
+	TaskID int64
+}
+
+// IsErrReminderRelativeToMissing checks if an error is ErrReminderRelativeToMissing.
+func IsErrReminderRelativeToMissing(err error) bool {
+	_, ok := err.(ErrReminderRelativeToMissing)
+	return ok
+}
+
+func (err ErrReminderRelativeToMissing) Error() string {
+	return fmt.Sprintf("Task [TaskID: %v] has a relative reminder without relative_to", err.TaskID)
+}
+
+// ErrCodeRelationDoesNotExist holds the unique world-error code of this error
+const ErrCodeReminderRelativeToMissing = 4022
+
+// HTTPError holds the http error description
+func (err ErrReminderRelativeToMissing) HTTPError() web.HTTPError {
+	return web.HTTPError{
+		HTTPCode: http.StatusBadRequest,
+		Code:     ErrCodeReminderRelativeToMissing,
+		Message:  "Relative reminder without relative_to",
+	}
+}
+
 // =================
 // Namespace errors
 // =================

pkg/models/tasks.go

@@ -1510,7 +1510,7 @@ func (t *Task) overwriteRemindersWithReminderDates(reminderDates []time.Time) {
 }
 
 // Set the absolute trigger dates for Reminders with relative period
-func updateRelativeReminderDates(task *Task) {
+func updateRelativeReminderDates(task *Task) (err error) {
 	for _, reminder := range task.Reminders {
 		relativeDuration := time.Duration(reminder.RelativePeriod) * time.Second
 		switch reminder.RelativeTo {
@@ -1526,8 +1526,16 @@ func updateRelativeReminderDates(task *Task) {
 			if !task.EndDate.IsZero() {
 				reminder.Reminder = task.EndDate.Add(relativeDuration)
 			}
+		default:
+			if reminder.RelativePeriod != 0 {
+				err = ErrReminderRelativeToMissing{
+					TaskID: task.ID,
+				}
+			}
+			return err
 		}
 	}
+	return nil
 }
 
 // Removes all old reminders and adds the new ones. This is a lot easier and less buggy than
@@ -1548,7 +1556,10 @@ func (t *Task) updateReminders(s *xorm.Session, task *Task) (err error) {
 		return
 	}
 
-	updateRelativeReminderDates(task)
+	err = updateRelativeReminderDates(task)
+	if err != nil {
+		return
+	}
 
 	// Resolve duplicates and sort them
 	reminderMap := make(map[int64]*TaskReminder, len(task.Reminders))