waza-ari
  • Joined on 2023-11-16
waza-ari commented on pull request vikunja/vikunja#2152 2024-03-04 17:50:36 +00:00
fix: OIDC team comparison should not include the team name

Anyway, since the sync also removes old teams when no one is part of that team any more, it seems like the problem of "old teams without an issuer remaining" is not a problem.

Now that you…

waza-ari commented on pull request vikunja/vikunja#2152 2024-03-04 17:48:09 +00:00
fix: OIDC team comparison should not include the team name

It's probably not a real problem. Maybe best to just ignore the problem and let users who are already using this (probably us two) delete the old teams manually with a `delete from teams where…

waza-ari commented on pull request vikunja/vikunja#2152 2024-03-04 17:26:07 +00:00
fix: OIDC team comparison should not include the team name

It looks like the issuer is not set for old teams. I propose two solutions:

  1. Update the issuer when the team is updated (for the name)
  2. Delete all openid teams in the migration so…
waza-ari pushed to fix-team-creation at waza-ari/vikunja 2024-03-04 17:21:40 +00:00
3bd427c870 fix: wording in error message
waza-ari commented on pull request vikunja/vikunja#2152 2024-03-04 16:55:42 +00:00
fix: OIDC team comparison should not include the team name

@konrad thanks, you're absolutely right. The PR should work as is, avoiding duplicate teams being created and leveraging the issuer to compare against existing teams.

I've not found an easy…

waza-ari pushed to fix-team-creation at waza-ari/vikunja 2024-03-04 16:52:09 +00:00
ea04c6cbe3 fix: OIDC team IDs should be bound to an issuer
185e63baf0 fix: OIDC team comparison should not include the team name
63e9f8f682 fix(deps): update module github.com/arran4/golang-ical to v0.2.7
5a9de579cc fix(deps): update module golang.org/x/sys to v0.18.0
Compare 4 commits »
waza-ari pushed to fix-team-creation at waza-ari/vikunja 2024-03-04 16:31:14 +00:00
9a20596bb0 fix: OIDC team IDs should be bound to an issuer
a04adf42c3 fix: OIDC team comparison should not include the team name
42e660c3d6 fix(deps): update dependency vue-i18n to v9.10.1
6533e75496 fix(deps): update module github.com/stretchr/testify to v1.9.0
f8c5e314df fix(deps): update sentry-javascript monorepo to v7.105.0
Compare 13 commits »
waza-ari pushed to fix-team-creation at waza-ari/vikunja 2024-03-04 16:30:41 +00:00
3a609d4d89 fix: OIDC team IDs should be bound to an issuer
waza-ari commented on pull request vikunja/vikunja#2152 2024-03-04 15:14:47 +00:00
fix: OIDC team comparison should not include the team name

@konrad I'll work on that today, I believe it should be reasonable straight forward. One item for discussion though:

Right now, whenever a Team is created, the user who logged in and triggered…

waza-ari pushed to fix-team-creation at waza-ari/vikunja 2024-03-04 13:55:08 +00:00
221359bb2e fix(deps): update dependency vue-i18n to v9.10.1
d50bfcbfac fix(deps): update module github.com/stretchr/testify to v1.9.0
4b5b8f593d fix(deps): update sentry-javascript monorepo to v7.105.0
b05c3c381a chore(deps): update dependency vue-tsc to v2
e796e054b5 chore(deps): update dev-dependencies
Compare 11 commits »
waza-ari commented on issue vikunja/vikunja#2153 2024-03-04 13:46:26 +00:00
Add ability to configure default project view

Okay that makes a lot of sense. The first option you mentioned there (make it configurable on a per project level). Imho it should still allow the user to make their choice (among the available…

waza-ari closed pull request vikunja/vikunja#2154 2024-03-04 13:44:12 +00:00
feat: add config flag to configure default project view
waza-ari commented on pull request vikunja/vikunja#2154 2024-03-04 13:44:11 +00:00
feat: add config flag to configure default project view

Okay no worries. Guess it was a nice starter exercise to get into Go and Vue a little bit. I saw the item on the public roadmap a little bit later and figured that it would've been better to first…

waza-ari commented on pull request vikunja/vikunja#2151 2024-03-03 22:04:45 +00:00
docs: improve OpenID documentation

Added the scope parameter at the beginning because it was not mentioned anywhere else, before later adding the general schema in openid.md. Removed them again for all examples as its not needed.

waza-ari pushed to main at waza-ari/vikunja 2024-03-03 22:03:19 +00:00
6987ddae2a docs: implement requested doc changes
waza-ari commented on pull request vikunja/vikunja#2152 2024-03-03 21:54:10 +00:00
fix: OIDC team comparison should not include the team name

Well I just noticed the oidc id is not enough, it should actually also use the openid provider id as well… since the id is only guaranteed to be unique within that one provider. We should…

waza-ari commented on pull request vikunja/vikunja#2152 2024-03-03 21:51:27 +00:00
fix: OIDC team comparison should not include the team name

I left it in there because it's currently passed to the ErrOIDCTeamDoesNotExist exception, and then used in various places in the code. If you prefer I can remove those occurrences, although it…

waza-ari commented on issue vikunja/vikunja#2150 2024-03-03 21:47:54 +00:00
OIDC Team Assignment - Feedback

Currently, it's not possible to configure this with environment variables. The documentation of the individual variables is configured from the config.yml.sample file and the comments it…

waza-ari commented on issue vikunja/vikunja#2155 2024-03-03 14:55:18 +00:00
Links in description open two tabs

Reproducible for me also in Firefox on Mac OS X, not reproducible in Safari, Chrome or Edge.

waza-ari pushed to add-default-view at waza-ari/vikunja 2024-03-03 08:20:40 +00:00
290c4d0e7b fix: do not use computed outside of components...