From 20ede346b48ef1bc4375e0030df21ee5f5f520eb Mon Sep 17 00:00:00 2001 From: kolaente Date: Sun, 16 May 2021 13:28:15 +0200 Subject: [PATCH] Only filter out failing openid providers if multiple are configured and one of them failed --- pkg/modules/auth/openid/providers.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/modules/auth/openid/providers.go b/pkg/modules/auth/openid/providers.go index 7c2c51affe..436bd7abf9 100644 --- a/pkg/modules/auth/openid/providers.go +++ b/pkg/modules/auth/openid/providers.go @@ -17,6 +17,7 @@ package openid import ( + "code.vikunja.io/api/pkg/log" "context" "regexp" "strconv" @@ -48,7 +49,11 @@ func GetAllProviders() (providers []*Provider, err error) { provider, err := getProviderFromMap(pi) if err != nil { - return nil, err + if provider != nil { + log.Errorf("Error while getting openid provider %s: %s", provider.Name, err) + } + log.Errorf("Error while getting openid provider: %s", err) + continue } providers = append(providers, provider) @@ -119,7 +124,7 @@ func getProviderFromMap(pi map[interface{}]interface{}) (*Provider, error) { var err error provider.OpenIDProvider, err = oidc.NewProvider(context.Background(), provider.AuthURL) if err != nil { - return nil, err + return provider, err } provider.Oauth2Config = &oauth2.Config{