zewaren
/
api
forked from vikunja/vikunja
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(caldav): do not update dates of tasks when repositioning them 

When a task is updated, the position of the tasks of the whole
project/bucket are updated. This leads to column "updated" of
model Task to be updated quite often.
However, that column is used for the ETag field of CALDAV.
Thus, changing a task marks all the other tasks as updated, which
prevents clients from synchronizing their edited tasks.
This commit is contained in:
Erwan Martin 2023-09-17 17:35:09 +02:00
parent f065dcf4ad
commit 4f55099896
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/models/tasks.go
View File

@ -1083,6 +1083,7 @@ func recalculateTaskKanbanPositions(s *xorm.Session, bucketID int64) (err error)
_, err = s.Cols("kanban_position").
Where("id = ?", task.ID).
NoAutoTime().
Update(&Task{KanbanPosition: currentPosition})
if err != nil {
return
@ -1111,6 +1112,7 @@ func recalculateTaskPositions(s *xorm.Session, projectID int64) (err error) {
_, err = s.Cols("position").
Where("id = ?", task.ID).
NoAutoTime().
Update(&Task{Position: currentPosition})
if err != nil {
return