feat: check link share auth from store instead

This commit is contained in:
kolaente 2023-04-01 17:56:30 +02:00
parent a33e2f6c00
commit c2ffe3a9dc
Signed by untrusted user: konrad
GPG Key ID: F40E70337AB24C9B
2 changed files with 14 additions and 13 deletions

View File

@ -56,11 +56,13 @@ import {useOnline} from '@/composables/useOnline'
import {getAuthForRoute} from '@/router' import {getAuthForRoute} from '@/router'
import {useBaseStore} from '@/stores/base' import {useBaseStore} from '@/stores/base'
import {useAuthStore} from '@/stores/auth'
const router = useRouter() const router = useRouter()
const route = useRoute() const route = useRoute()
const baseStore = useBaseStore() const baseStore = useBaseStore()
const authStore = useAuthStore()
const ready = computed(() => baseStore.ready) const ready = computed(() => baseStore.ready)
const online = useOnline() const online = useOnline()
@ -72,7 +74,7 @@ async function load() {
try { try {
await baseStore.loadApp() await baseStore.loadApp()
baseStore.setReady(true) baseStore.setReady(true)
const redirectTo = await getAuthForRoute(route) const redirectTo = await getAuthForRoute(route, authStore)
if (typeof redirectTo !== 'undefined') { if (typeof redirectTo !== 'undefined') {
await router.push(redirectTo) await router.push(redirectTo)
} }

View File

@ -6,7 +6,6 @@ import {saveProjectView, getProjectView} from '@/helpers/projectView'
import {parseDateOrString} from '@/helpers/time/parseDateOrString' import {parseDateOrString} from '@/helpers/time/parseDateOrString'
import {getNextWeekDate} from '@/helpers/time/getNextWeekDate' import {getNextWeekDate} from '@/helpers/time/getNextWeekDate'
import {setTitle} from '@/helpers/setTitle' import {setTitle} from '@/helpers/setTitle'
import {getToken} from '@/helpers/auth'
import {LINK_SHARE_HASH_PREFIX} from '@/constants/linkShareHash' import {LINK_SHARE_HASH_PREFIX} from '@/constants/linkShareHash'
import {useProjectStore} from '@/stores/projects' import {useProjectStore} from '@/stores/projects'
@ -444,8 +443,7 @@ const router = createRouter({
], ],
}) })
export async function getAuthForRoute(route: RouteLocation) { export async function getAuthForRoute(to: RouteLocation, authStore) {
const authStore = useAuthStore()
if (authStore.authUser || authStore.authLinkShare) { if (authStore.authUser || authStore.authLinkShare) {
return return
} }
@ -466,31 +464,32 @@ export async function getAuthForRoute(route: RouteLocation) {
'user.register', 'user.register',
'link-share.auth', 'link-share.auth',
'openid.auth', 'openid.auth',
].includes(route.name as string) && ].includes(to.name as string) &&
localStorage.getItem('passwordResetToken') === null && localStorage.getItem('passwordResetToken') === null &&
localStorage.getItem('emailConfirmToken') === null && localStorage.getItem('emailConfirmToken') === null &&
!(route.name === 'home' && (typeof route.query.userPasswordReset !== 'undefined' || typeof route.query.userEmailConfirm !== 'undefined')) !(to.name === 'home' && (typeof to.query.userPasswordReset !== 'undefined' || typeof to.query.userEmailConfirm !== 'undefined'))
) { ) {
saveLastVisited(route.name as string, route.params, route.query) saveLastVisited(to.name as string, to.params, to.query)
return {name: 'user.login'} return {name: 'user.login'}
} }
if(localStorage.getItem('passwordResetToken') !== null && route.name !== 'user.password-reset.reset') { if(localStorage.getItem('passwordResetToken') !== null && to.name !== 'user.password-reset.reset') {
return {name: 'user.password-reset.reset'} return {name: 'user.password-reset.reset'}
} }
if(localStorage.getItem('emailConfirmToken') !== null && route.name !== 'user.login') { if(localStorage.getItem('emailConfirmToken') !== null && to.name !== 'user.login') {
return {name: 'user.login'} return {name: 'user.login'}
} }
} }
router.beforeEach(async (to, from) => { router.beforeEach(async (to, from) => {
const authStore = useAuthStore()
if(from.hash && from.hash.startsWith(LINK_SHARE_HASH_PREFIX)) { if(from.hash && from.hash.startsWith(LINK_SHARE_HASH_PREFIX)) {
to.hash = from.hash to.hash = from.hash
} }
if (to.hash.startsWith(linkShareHashPrefix) && getToken() === null) { if (to.hash.startsWith(LINK_SHARE_HASH_PREFIX) && !authStore.authLinkShare) {
saveLastVisited(to.name as string, to.params, to.query) saveLastVisited(to.name as string, to.params, to.query)
return { return {
name: 'link-share.auth', name: 'link-share.auth',
@ -499,8 +498,8 @@ router.beforeEach(async (to, from) => {
}, },
} }
} }
const newRoute = await getAuthForRoute(to) const newRoute = await getAuthForRoute(to, authStore)
if(newRoute) { if(newRoute) {
return { return {
...newRoute, ...newRoute,