feat: lists store with composition api (#2606)

Co-authored-by: Dominik Pschenitschni <mail@celement.de>
Reviewed-on: #2606
Reviewed-by: konrad <k@knt.li>
Co-authored-by: Dominik Pschenitschni <dpschen@noreply.kolaente.de>
Co-committed-by: Dominik Pschenitschni <dpschen@noreply.kolaente.de>

src/stores/lists.ts

@@ -1,4 +1,4 @@
-import {watch, reactive, shallowReactive, unref, toRefs, readonly} from 'vue'
+import {watch, reactive, shallowReactive, unref, toRefs, readonly, ref, computed} from 'vue'
 import {acceptHMRUpdate, defineStore} from 'pinia'
 import {useI18n} from 'vue-i18n'
 
@@ -21,105 +21,101 @@ const {add, remove, search, update} = createNewIndexer('lists', ['title', 'descr
 const FavoriteListsNamespace = -2
 
 export interface ListState {
-	lists: { [id: IList['id']]: IList },
-	isLoading: boolean,
+	[id: IList['id']]: IList
 }
 
-export const useListStore = defineStore('list', {
-	state: () : ListState => ({
-		isLoading: false,
+export const useListStore = defineStore('list', () => {
+	const baseStore = useBaseStore()
+	const namespaceStore = useNamespaceStore()
+
+	const isLoading = ref(false)
+
 	// The lists are stored as an object which has the list ids as keys.
-		lists: {},
-	}),
+	const lists = ref<ListState>({})
 
-	getters: {
-		getListById(state) {
-			return (id: IList['id']) => typeof state.lists[id] !== 'undefined' ? state.lists[id] : null
-		},
 
-		findListByExactname(state) {
+	const getListById = computed(() => {
+		return (id: IList['id']) => typeof lists.value[id] !== 'undefined' ? lists.value[id] : null
+	})
+
+	const findListByExactname = computed(() => {
 		return (name: string) => {
-				const list = Object.values(state.lists).find(l => {
+			const list = Object.values(lists.value).find(l => {
 				return l.title.toLowerCase() === name.toLowerCase()
 			})
 			return typeof list === 'undefined' ? null : list
 		}
-		},
+	})
 
-		searchList(state) {
+	const searchList = computed(() => {
 		return (query: string, includeArchived = false) => {
 			return search(query)
 				?.filter(value => value > 0)
-					.map(id => state.lists[id])
+				.map(id => lists.value[id])
 				.filter(list => list.isArchived === includeArchived)
 				|| []
 		}
-		},
-	},
+	})
 
-	actions: {
-		setIsLoading(isLoading: boolean) {
-			this.isLoading = isLoading
-		},
+	function setIsLoading(newIsLoading: boolean) {
+		isLoading.value = newIsLoading
+	}
 
-		setList(list: IList) {
-			this.lists[list.id] = list
+	function setList(list: IList) {
+		lists.value[list.id] = list
 		update(list)
 
-			const baseStore = useBaseStore()
 		if (baseStore.currentList?.id === list.id) {
 			baseStore.setCurrentList(list)
 		}
-		},
+	}
 
-		setLists(lists: IList[]) {
-			lists.forEach(l => {
-				this.lists[l.id] = l
+	function setLists(newLists: IList[]) {
+		newLists.forEach(l => {
+			lists.value[l.id] = l
 			add(l)
 		})
-		},
+	}
 
-		removeListById(list: IList) {
+	function removeListById(list: IList) {
 		remove(list)
-			delete this.lists[list.id]
-		},
+		delete lists.value[list.id]
+	}
 
-		toggleListFavorite(list: IList) {
+	function toggleListFavorite(list: IList) {
 		// The favorites pseudo list is always favorite
 		// Archived lists cannot be marked favorite
 		if (list.id === -1 || list.isArchived) {
 			return
 		}
-			return this.updateList({
+		return updateList({
 			...list,
 			isFavorite: !list.isFavorite,
 		})
-		},
+	}
 
-		async createList(list: IList) {
-			const cancel = setModuleLoading(this)
+	async function createList(list: IList) {
+		const cancel = setModuleLoading(this, setIsLoading)
 		const listService = new ListService()
 
 		try {
 			const createdList = await listService.create(list)
 			createdList.namespaceId = list.namespaceId
-				const namespaceStore = useNamespaceStore()
 			namespaceStore.addListToNamespace(createdList)
-				this.setList(createdList)
+			setList(createdList)
 			return createdList
 		} finally {
 			cancel()
 		}
-		},
+	}
 
-		async updateList(list: IList) {
-			const cancel = setModuleLoading(this)
+	async function updateList(list: IList) {
+		const cancel = setModuleLoading(this, setIsLoading)
 		const listService = new ListService()
 
 		try {
 			await listService.update(list)
-				this.setList(list)
-				const namespaceStore = useNamespaceStore()
+			setList(list)
 			namespaceStore.setListInNamespaceById(list)
 
 			// the returned list from listService.update is the same!
@@ -133,12 +129,12 @@ export const useListStore = defineStore('list', {
 			} else {
 				namespaceStore.removeListFromNamespaceById(newList)
 			}
-				namespaceStore.loadNamespacesIfFavoritesDontExist(null)
-				namespaceStore.removeFavoritesNamespaceIfEmpty(null)
+			namespaceStore.loadNamespacesIfFavoritesDontExist()
+			namespaceStore.removeFavoritesNamespaceIfEmpty()
 			return newList
 		} catch (e) {
 			// Reset the list state to the initial one to avoid confusion for the user
-				this.setList({
+			setList({
 				...list,
 				isFavorite: !list.isFavorite,
 			})
@@ -146,24 +142,39 @@ export const useListStore = defineStore('list', {
 		} finally {
 			cancel()
 		}
-		},
+	}
 
-		async deleteList(list: IList) {
-			const cancel = setModuleLoading(this)
+	async function deleteList(list: IList) {
+		const cancel = setModuleLoading(this, setIsLoading)
 		const listService = new ListService()
 
 		try {
 			const response = await listService.delete(list)
-				this.removeListById(list)
-				const namespaceStore = useNamespaceStore()
+			removeListById(list)
 			namespaceStore.removeListFromNamespaceById(list)
 			removeListFromHistory({id: list.id})
 			return response
 		} finally {
 			cancel()
 		}
-		},
-	},
+	}
+
+	return {
+		isLoading: readonly(isLoading),
+		lists: readonly(lists),
+
+		getListById,
+		findListByExactname,
+		searchList,
+
+		setList,
+		setLists,
+		removeListById,
+		toggleListFavorite,
+		createList,
+		updateList,
+		deleteList,
+	}
 })
 
 export function useList(listId: MaybeRef<IList['id']>) {