fix: don't use transitions for elements where it is not possible
continuous-integration/drone/push Build is passing Details

Resolves #2153
This commit is contained in:
kolaente 2022-07-19 16:56:09 +02:00
parent 6dc02c45dd
commit c2d5370e4a
Signed by: konrad
GPG Key ID: F40E70337AB24C9B
3 changed files with 10 additions and 14 deletions

View File

@ -10,9 +10,7 @@
</no-auth-wrapper> </no-auth-wrapper>
<Notification/> <Notification/>
<transition name="fade"> <keyboard-shortcuts v-if="keyboardShortcutsActive"/>
<keyboard-shortcuts v-if="keyboardShortcutsActive"/>
</transition>
</ready> </ready>
</template> </template>

View File

@ -38,16 +38,14 @@
</keep-alive> </keep-alive>
</router-view> </router-view>
<transition name="modal"> <modal
<modal v-if="currentModal"
v-if="currentModal" @close="closeModal()"
@close="closeModal()" variant="scrolling"
variant="scrolling" class="task-detail-view-modal"
class="task-detail-view-modal" >
> <component :is="currentModal"/>
<component :is="currentModal"/> </modal>
</modal>
</transition>
<BaseButton <BaseButton
class="keyboard-shortcuts-button d-print-none" class="keyboard-shortcuts-button d-print-none"

View File

@ -1,7 +1,7 @@
<template> <template>
<Teleport to="body"> <Teleport to="body">
<!-- FIXME: transition should not be included in the modal --> <!-- FIXME: transition should not be included in the modal -->
<transition name="modal"> <transition :name="transitionName">
<section <section
v-if="enabled" v-if="enabled"
class="modal-mask" class="modal-mask"