feat: ask for confirmation before deleting a label (#1996)
continuous-integration/drone/push Build is passing Details

Co-authored-by: kolaente <k@knt.li>
Reviewed-on: #1996
This commit is contained in:
konrad 2022-06-16 16:21:06 +00:00
parent 9d0415e24c
commit e468595ce4
2 changed files with 29 additions and 3 deletions

View File

@ -729,7 +729,12 @@
"addSuccess": "The label has been added successfully.", "addSuccess": "The label has been added successfully.",
"createSuccess": "The label has been created successfully.", "createSuccess": "The label has been created successfully.",
"removeSuccess": "The label has been removed successfully.", "removeSuccess": "The label has been removed successfully.",
"addCreateSuccess": "The label has been created and added successfully." "addCreateSuccess": "The label has been created and added successfully.",
"delete": {
"header": "Delete this label",
"text1": "Are you sure you want to delete this label?",
"text2": "This will remove it from all tasks and cannot be restored."
}
}, },
"priority": { "priority": {
"unset": "Unset", "unset": "Unset",

View File

@ -38,7 +38,7 @@
v-else> v-else>
{{ l.title }} {{ l.title }}
</a> </a>
<a @click="deleteLabel(l)" class="delete is-small" v-if="userInfo.id === l.createdBy.id"></a> <a @click="showDeleteDialoge(l)" class="delete is-small" v-if="userInfo.id === l.createdBy.id"></a>
</span> </span>
</div> </div>
<div class="column is-4" v-if="isLabelEdit"> <div class="column is-4" v-if="isLabelEdit">
@ -83,7 +83,7 @@
</div> </div>
<div class="control"> <div class="control">
<x-button <x-button
@click="() => {deleteLabel(labelEditLabel);isLabelEdit = false}" @click="showDeleteDialoge(labelEditLabel)"
icon="trash-alt" icon="trash-alt"
class="is-danger" class="is-danger"
/> />
@ -92,6 +92,19 @@
</form> </form>
</card> </card>
</div> </div>
<modal
@close="showDeleteModal = false"
@submit="deleteLabel(labelToDelete)"
v-if="showDeleteModal"
>
<template #header><span>{{ $t('task.label.delete.header') }}</span></template>
<template #text>
<p>{{ $t('task.label.delete.text1') }}<br/>
{{ $t('task.label.delete.text2') }}</p>
</template>
</modal>
</div> </div>
</div> </div>
</template> </template>
@ -117,6 +130,8 @@ export default defineComponent({
labelEditLabel: new LabelModel(), labelEditLabel: new LabelModel(),
isLabelEdit: false, isLabelEdit: false,
editorActive: false, editorActive: false,
showDeleteModal: false,
labelToDelete: null,
} }
}, },
created() { created() {
@ -133,6 +148,8 @@ export default defineComponent({
}), }),
methods: { methods: {
deleteLabel(label) { deleteLabel(label) {
this.showDeleteModal = false
this.isLabelEdit = false
return this.$store.dispatch('labels/deleteLabel', label) return this.$store.dispatch('labels/deleteLabel', label)
}, },
editLabelSubmit() { editLabelSubmit() {
@ -160,6 +177,10 @@ export default defineComponent({
this.editorActive = false this.editorActive = false
this.$nextTick(() => this.editorActive = true) this.$nextTick(() => this.editorActive = true)
}, },
showDeleteDialoge(label) {
this.labelToDelete = label
this.showDeleteModal = true
},
}, },
}) })
</script> </script>