vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: restrict list name length in singleTaskInList #1039

Closed
dpschen wants to merge 1 commits from dpschen/frontend:feature/fix-long-list-name into main
pull from: dpschen/frontend:feature/fix-long-list-name
merge into: vikunja:main
Conversation 6 Commits 1 Files Changed 1 +15 -7
dpschen commented 2021-11-19 13:15:05 +00:00
Member
Copy Link
No description provided.
frederick commented 2021-11-19 13:19:21 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1039-featurefix-long-list-name--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1039-featurefix-long-list-name--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad was assigned by dpschen 2021-11-21 12:50:35 +00:00
dpschen requested review from konrad 2021-11-21 12:50:39 +00:00
konrad requested changes 2021-11-22 18:37:44 +00:00
konrad left a comment
Owner

It looks like this breaks the alignment:

image

It looks like this breaks the alignment: ![image](/attachments/e9f1292f-7e36-4474-be5f-c2a4308e8e7a)
image.png
6.9 KiB
dpschen force-pushed feature/fix-long-list-name from e97a6163a3 to 5cf7a55b90 2021-11-22 20:17:48 +00:00 Compare
dpschen commented 2021-11-22 20:19:06 +00:00
Author
Member
Copy Link

Solved by moving the list link out of the task link. That was a mistake either way: links should never be nested.

Solved by moving the list link out of the task link. That was a mistake either way: links should never be nested.
dpschen requested review from konrad 2021-11-22 20:19:12 +00:00
konrad requested changes 2021-11-22 20:50:39 +00:00
konrad left a comment
Owner

Looks like there's a space missing now:

image

Looks like there's a space missing now: ![image](/attachments/a1d2f584-9a3d-4d7e-9817-6975da01a66a)
image.png
9.3 KiB
konrad removed their assignment 2021-11-23 21:01:15 +00:00
dpschen was assigned by konrad 2021-11-23 21:01:15 +00:00
dpschen force-pushed feature/fix-long-list-name from 5cf7a55b90 to 568b278c1b 2021-12-10 12:10:16 +00:00 Compare
dpschen commented 2021-12-10 12:11:20 +00:00
Author
Member
Copy Link

Looks like there's a space missing now:

Fixed.

> Looks like there's a space missing now: Fixed.
dpschen requested review from konrad 2021-12-10 12:11:37 +00:00
konrad was assigned by dpschen 2021-12-10 12:11:41 +00:00
dpschen removed their assignment 2021-12-10 12:11:45 +00:00
konrad commented 2021-12-11 13:00:14 +00:00
Owner
Copy Link

Now the spacing is fixed but the original issue is not:

image

Now the spacing is fixed but the original issue is not: ![image](/attachments/673a2e2d-00ea-4356-913d-d205c0e41d44)
image.png
19 KiB
😆 1
dpschen commented 2021-12-11 13:01:38 +00:00
Author
Member
Copy Link

Ok closing this then… Sry for the work.

I have continued on this, but is still incomplete. Will reopen with a better (tested) and more complete version.

Ok closing this then… Sry for the work. I have continued on this, but is still incomplete. Will reopen with a better (tested) and more complete version.
👍 1
dpschen closed this pull request 2021-12-11 13:01:43 +00:00
konrad commented 2021-12-11 13:01:58 +00:00
Owner
Copy Link

No worries!

No worries!
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1039
No description provided.
Delete Branch "dpschen/frontend:feature/fix-long-list-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?