fix: show namespace count for long titles #1057

dpschen · 2021-11-22T12:55:38Z

dpschen commented

2021-11-22 12:55:38 +00:00

When the namespace title is to long the count was only shown in the toolip. With this pull request the count is separated from the title and always shown.

dpschen added 1 commit 2021-11-22 12:55:39 +00:00

continuous-integration/drone/pr Build is passing Details

23ff6f8502

fix: show namespace count for long titles

When the namespace title is to long the count was only shown in the toolip. With this pull request the count is separated from the title and always shown.

frederick commented

2021-11-22 13:04:20 +00:00

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1057-featurefix-namespace-count-for-long-titles--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1057-featurefix-namespace-count-for-long-titles--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad requested changes 2021-11-22 19:13:58 +00:00

konrad left a comment

I think it should keep the braces, like it does currencly. Like this:

And maybe the count could be positioned right after the title as well?

I think it should keep the braces, like it does currencly. Like this: ![image](/attachments/a2749952-595b-4290-a766-22be30689db8) And maybe the count could be positioned right after the title as well?

image.png

4.5 KiB

dpschen commented

2021-11-22 20:00:39 +00:00

I removed the braces to add more space for displaying the title since there is now less space available =)

What do you mean by:

And maybe the count could be positioned right after the title as well?

I removed the braces to add more space for displaying the title since there is now less space available =) What do you mean by: > And maybe the count could be positioned right after the title as well?

konrad commented

2021-11-22 20:35:18 +00:00

What do you mean by:

And maybe the count could be positioned right after the title as well?

Currently, the count is positioned at the end of the title for titles when it is not overflowing:

I'd like to keep it that way.

When overflowing, I think the count should be pushed to the right, as you implemented it. But I feel like the "naked" numbers are a bit confusing without the braces.

> What do you mean by: > > > And maybe the count could be positioned right after the title as well? Currently, the count is positioned at the end of the title for titles when it is not overflowing: ![image](/attachments/77095a1f-c677-4d2f-9fd5-7575081d9352) I'd like to keep it that way. When overflowing, I think the count should be pushed to the right, as you implemented it. But I feel like the "naked" numbers are a bit confusing without the braces.

image.png

3.1 KiB

dpschen was assigned by konrad

2021-11-23 18:14:16 +00:00

konrad commented

2021-12-25 20:58:54 +00:00

@dpschen What's the status here?

konrad added 2 commits 2022-01-18 21:54:14 +00:00

22840188eb

Merge branch 'main' into feature/fix-namespace-count-for-long-titles

continuous-integration/drone/pr Build was killed Details

509c55440d