vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: related tasks add button and task dates in read only view #1268

Merged
konrad merged 5 commits from fix/read-only-layout into main 2022-02-06 15:58:53 +00:00
Conversation 2 Commits 5 Files Changed 3 +69 -52
konrad commented 2021-12-30 16:52:39 +00:00
Owner
Copy Link

Fixes #1052 and the "created/updated/done at" at the bottom right corner for read only views.

Fixes #1052 and the "created/updated/done at" at the bottom right corner for read only views.
konrad added 1 commit 2021-12-30 16:52:40 +00:00
dpschen reviewed 2022-01-04 20:36:22 +00:00
src/components/tasks/partials/createdUpdated.vue Outdated
@ -0,0 +25,4 @@
import TaskModel from '@/models/task'
import {formatDateLong, formatDateSince} from '@/helpers/time/formatDate'
const {task} = defineProps({
dpschen commented 2022-01-04 20:36:22 +00:00
Member

As the failing test says:

/drone/src/src/components/tasks/partials/createdUpdated.vue
  28:7  error  Destructuring the `props` will cause the value to lose reactivity  vue/no-setup-props-destructure
  32:3  error  Missing trailing comma                                             comma-dangle

*EDIT: you can however use toRefs and then use task.value

As the failing test says: ``` /drone/src/src/components/tasks/partials/createdUpdated.vue 28:7 error Destructuring the `props` will cause the value to lose reactivity vue/no-setup-props-destructure 32:3 error Missing trailing comma comma-dangle ``` ***EDIT:** you can however use [toRefs](https://v3.vuejs.org/api/refs-api.html#torefs) and then use `task.value`
konrad commented 2022-01-08 11:41:43 +00:00
Author
Owner

Changed it to use toRefs.

Changed it to use `toRefs`.
konrad marked this conversation as resolved
dpschen requested changes 2022-01-04 20:43:04 +00:00
src/views/tasks/TaskDetailView.vue Outdated
@ -249,2 +249,2 @@
<div class="column is-one-third action-buttons">
<a @click="$router.back()" class="is-fullwidth is-block has-text-centered mb-4" v-if="shouldShowClosePopup">
<div class="column is-one-third action-buttons" v-if="canWrite || shouldShowClosePopup">
<a @click="$router.back()" class="is-fullwidth is-block has-text-centered mb-4">
dpschen commented 2022-01-04 20:38:02 +00:00
Member

Should be a <BaseButton>

Should be a `<BaseButton>`
konrad commented 2022-01-08 11:45:52 +00:00
Author
Owner

Done.

Done.
konrad marked this conversation as resolved
src/views/tasks/TaskDetailView.vue Outdated
@ -697,239 +671,239 @@ export default {
$flash-background-duration: 750ms;
.task-view {
dpschen commented 2022-01-04 20:42:56 +00:00
Member

Reduce diff.
We should separate formatting commits and changing commits.
If we mix both in the same it's hard to track changes.
Best would be to wait for #930 and then use prettier (it also formats CSS).

Reduce diff. We should separate formatting commits and changing commits. If we mix both in the same it's hard to track changes. Best would be to wait for https://kolaente.dev/vikunja/frontend/pulls/930 and then use prettier (it also formats CSS).
konrad commented 2022-01-08 11:49:51 +00:00
Author
Owner

I've converted this back to spaces which greatly minimized the diff. There's still some diff that seems unrelated but I think it should be fine now.

I've converted this back to spaces which greatly minimized the diff. There's still some diff that seems unrelated but I think it should be fine now.
konrad marked this conversation as resolved
konrad added 1 commit 2022-01-08 11:41:31 +00:00
continuous-integration/drone/pr Build was killed Details
ee6d43de53
fix: reactivity for prop
konrad added 2 commits 2022-01-08 11:45:46 +00:00
continuous-integration/drone/pr Build was killed Details
3702b2f1b4
chore: use BaseButton
konrad added 1 commit 2022-01-08 11:48:48 +00:00
continuous-integration/drone/pr Build is passing Details
4f752b4c25
chore: re-add spaces instead of tabs
konrad requested review from dpschen 2022-01-08 11:49:53 +00:00
frederick commented 2022-01-08 11:56:28 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1268-fixread-only-layout--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1268-fixread-only-layout--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen was assigned by konrad 2022-01-08 12:54:23 +00:00
dpschen approved these changes 2022-02-06 15:16:08 +00:00
konrad force-pushed fix/read-only-layout from 4f752b4c25 to 551ec184bf 2022-02-06 15:44:25 +00:00 Compare
konrad commented 2022-02-06 15:44:44 +00:00
Author
Owner
Copy Link

Will merge once the ci passes.

Will merge once the ci passes.
konrad merged commit 581b2cb4ab into main 2022-02-06 15:58:53 +00:00
konrad deleted branch fix/read-only-layout 2022-02-06 15:58:53 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dpschen
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1268
No description provided.
Delete Branch "fix/read-only-layout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?