WIP: Changed the "Done button" to read "Mark task done" #1296

dmorlitz · 2022-01-04T17:41:03Z

dmorlitz commented

2022-01-04 17:41:03 +00:00

The text of "Done" on the button while editing a task is confusing and has been changed to "Mark task done" The original done button appears to be mean "done with editing" when it really does not.

dmorlitz added 2 commits 2022-01-04 17:41:03 +00:00

764f3cbd09 Changed button text "Done" to "Mark task done" to avoid confusion when editing a task - where "Done" could mean "done editing" or "mark task done"

continuous-integration/drone/pr Build is failing Details

aabe435aaa Changed test to find Done button to be based on cy-data not actual string

frederick commented

2022-01-04 17:43:32 +00:00

Hi dmorlitz!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1296-main--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dmorlitz! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1296-main--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dmorlitz changed title from ~~Changed the "Done button" to read "Mark task done"~~ to WIP: Changed the "Done button" to read "Mark task done"

2022-01-04 17:53:02 +00:00

dmorlitz closed this pull request

2022-01-04 18:36:06 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers