vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: add timezone setting #1379

Merged
konrad merged 2 commits from feature/timezone-setting into main 2022-02-06 15:23:02 +00:00
Conversation 2 Commits 2 Files Changed 5 +50 -13
konrad commented 2022-01-14 21:03:22 +00:00
Owner
Copy Link

Frontend for vikunja/api#1092

Frontend for https://kolaente.dev/vikunja/api/pulls/1092
konrad added 2 commits 2022-01-14 21:03:22 +00:00
continuous-integration/drone/pr Build is passing Details
98d357be34
feat: add setting for time zone to user settings
frederick commented 2022-01-14 21:55:08 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1379-featuretimezone-setting--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1379-featuretimezone-setting--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/timezone-setting from 98d357be34 to 085843a0eb 2022-02-06 15:02:13 +00:00 Compare
dpschen approved these changes 2022-02-06 15:02:23 +00:00
src/http-common/index.js Outdated
@ -6,2 +7,4 @@
})
}
export const AuthenticatedHTTPFactory = (token = null) => {
dpschen commented 2022-01-15 21:53:51 +00:00
Member
  • Make this a function.
  • (token = getToken()) => I think that the function will not be called if token is defined so the result should be identical.
- Make this a `function`. - `(token = getToken())` => I think that the function will not be called if `token` is defined so the result should be identical.
dpschen commented 2022-02-06 15:02:37 +00:00
Member

Changed!

Changed!
dpschen marked this conversation as resolved
src/views/user/settings/General.vue Outdated
@ -158,0 +180,4 @@
availableTimezones.value = r.data.sort()
})
return {
dpschen commented 2022-02-06 14:53:52 +00:00
Member

If only returning one ref from a composable it's better to not wrap it.

If only returning one ref from a composable it's better to not wrap it.
dpschen commented 2022-02-06 15:02:43 +00:00
Member

Changed!

Changed!
dpschen marked this conversation as resolved
dpschen force-pushed feature/timezone-setting from 085843a0eb to a812793ead 2022-02-06 15:04:16 +00:00 Compare
konrad commented 2022-02-06 15:22:36 +00:00
Author
Owner
Copy Link

Awesome! Thanks for reviewing and fixing.

Awesome! Thanks for reviewing and fixing.
konrad merged commit 2ea3499bf7 into main 2022-02-06 15:23:02 +00:00
konrad deleted branch feature/timezone-setting 2022-02-06 15:23:02 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1379
No description provided.
Delete Branch "feature/timezone-setting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?