feat: convert api-config to script setup and ts #1535

dpschen · 2022-02-13T16:03:48Z

dpschen commented

2022-02-13 16:03:48 +00:00

No description provided.

dpschen added 1 commit 2022-02-13 16:03:49 +00:00

continuous-integration/drone/pr Build is passing Details

583a083fa6

feat: convert api-config to script setup and ts

frederick commented

2022-02-13 16:42:40 +00:00

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1535-featurefeat-convert-api-config-to-ts-and-script-setup--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1535-featurefeat-convert-api-config-to-ts-and-script-setup--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen requested review from konrad 2022-02-13 19:47:47 +00:00

konrad was assigned by dpschen

2022-02-13 19:47:52 +00:00

konrad approved these changes 2022-02-13 22:05:15 +00:00

konrad commented

2022-02-13 22:06:22 +00:00

Looks like the error message when there's no vikunja api at the url provided is wrong, but that's already broken in the current main. Not a blocker, merging this.

We should fix this at some point though.

Looks like the error message when there's no vikunja api at the url provided is wrong, but that's already broken in the current main. Not a blocker, merging this. We should fix this at some point though.

konrad merged commit b84fe4c88b into main

2022-02-13 22:06:27 +00:00

konrad deleted branch feature/feat-convert-api-config-to-ts-and-script-setup

2022-02-13 22:06:27 +00:00

konrad referenced this issue from a commit

2022-02-13 22:06:27 +00:00

feat: convert api-config to script setup and ts (#1535)

dpschen commented

2022-02-13 22:08:23 +00:00

Looks like the error message when there's no vikunja api at the url provided is wrong, but that's already broken in the current main. Not a blocker, merging this.

We should fix this at some point though.

Indeed

> Looks like the error message when there's no vikunja api at the url provided is wrong, but that's already broken in the current main. Not a blocker, merging this. > > We should fix this at some point though. Indeed

This repo is archived. You cannot comment on pull requests.

No reviewers