WIP: feat: add storybook with @storybook/builder-vite #1785
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#1785
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/storybook"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This helps building components that work in isolation.
As the current example shows we can use it for components but could also use it later for full pages.
This would help us build pages that are only prop & event driven.
Having storybook could help us as well to better understand where we rely on global Bulma styles.
I added this as a proposol. That's why it's not finished at all. E.g. we could add:
What do you think?
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://1785-feature-storybook--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
@konrad:
What do you think of using storybook?
@dpschen I think it's a very interesting thing from looking at it, but didn't had the time yet to properly check it out and test it.
Maybe an update about this:
I've been working with storbook for years at work, but I always had some problems with the setup. In the beginning it was issues with the webpack configuration, that was a bit solved by a very well written plugin to vue-cli. Now I use storybook-builder-vite here in order to use almost the same vite config (storybook needs some small differences).
I keep running in some issues with the storybook typing. This is realated to the fact that storybook is based on react and leaks some typings.
With storybook 7 these issues should be gone. They are working on separating the build system from the core (so that you can chose between webpack and vite and it's not just some plugin).
So maybe we should wait for storybook 7 to mature. As an alternative there is now https://histoire.dev written by Akryum (Guillaume Chau, vue core-team member and behind vue-devtools) which is based on vite from the start.
Wasn't this replaced by histoire?
Please rebase and reopen if you think this is still relevant.