vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: remove copy-to-clipboard #1797

Merged
konrad merged 1 commits from dpschen/frontend:feature/copy-to-clipboard into main 2022-04-23 15:58:30 +00:00
Conversation 6 Commits 1 Files Changed 9 +109 -89
dpschen commented 2022-04-10 00:16:55 +00:00
Member
Copy Link
No description provided.
dpschen force-pushed feature/copy-to-clipboard from ecec6aeb9b to e20a096669 2022-04-11 18:58:41 +00:00 Compare
dpschen changed title from WIP: feat: remove copy-to-clipboard to feat: remove copy-to-clipboard 2022-04-11 18:58:53 +00:00
dpschen force-pushed feature/copy-to-clipboard from e20a096669 to af11b10e3b 2022-04-17 22:43:28 +00:00 Compare
frederick commented 2022-04-17 22:48:11 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1797-feature-copy-to-clipboard--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1797-feature-copy-to-clipboard--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2022-04-18 16:52:26 +00:00
Owner
Copy Link

Looks like this isn't quite working:

image

(tested with copying an attachment url on the netlify preview deploy)

Looks like this isn't quite working: ![image](/attachments/92f30f75-795d-4069-ad9e-c498d0df36fb) (tested with copying an attachment url on the netlify preview deploy)
image.png
1.8 KiB
dpschen commented 2022-04-18 19:24:44 +00:00
Author
Member
Copy Link

(tested with copying an attachment url on the netlify preview deploy)

Were you testing in the linkSharing component?
Because I forget to call useCopyToClipboard.

> (tested with copying an attachment url on the netlify preview deploy) Were you testing in the linkSharing component? Because I forget to call `useCopyToClipboard`.
konrad commented 2022-04-18 19:30:21 +00:00
Owner
Copy Link

Were you testing in the linkSharing component?

No, this was in the task detail view after uploading a new attachment.

> Were you testing in the linkSharing component? No, this was in the task detail view after uploading a new attachment.
👍 1
dpschen commented 2022-04-18 19:55:04 +00:00
Author
Member
Copy Link

Will check

Will check
dpschen force-pushed feature/copy-to-clipboard from 146ee3f476 to 7e51ed96f1 2022-04-23 11:50:28 +00:00 Compare
dpschen commented 2022-04-23 11:51:17 +00:00
Author
Member
Copy Link

I wrote the composable itself as async…

I wrote the composable itself as async…
konrad merged commit 17a42dc2e7 into main 2022-04-23 15:58:30 +00:00
konrad deleted branch feature/copy-to-clipboard 2022-04-23 15:58:30 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1797
No description provided.
Delete Branch "dpschen/frontend:feature/copy-to-clipboard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?