vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/feat-improve-ts-setup #1812

Merged
dpschen merged 10 commits from dpschen/frontend:feature/feat-improve-ts-setup into main 2022-07-04 21:50:50 +00:00
Conversation 7 Commits 10 Files Changed 69 +4 -4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 997b1bcedf - Show all commits

8
tsconfig.app.json
View File

@ -6,12 +6,12 @@
"composite": true,
"baseUrl": ".",
// "importHelpers": true,
"importHelpers": true,
dpschen marked this conversation as resolved Outdated
konrad commented 2022-04-18 17:17:18 +00:00
Outdated
Review
Copy Link

Isn't this invalid json with the //?

Isn't this invalid json with the `//`?
dpschen commented 2022-04-18 19:13:16 +00:00
Outdated
Review
Copy Link

Yes:

Yes: - https://github.com/microsoft/TypeScript/issues/4987 - https://www.reddit.com/r/typescript/comments/8na5vb/tsconfigjson_isnt_strict_json_what_now/
"sourceMap": true,
"strictNullChecks": true,
// "allowJs": true,
// "allowSyntheticDefaultImports": true,
dpschen marked this conversation as resolved Outdated
dpschen commented 2022-04-13 20:15:13 +00:00
Outdated
Review
Copy Link

I was not sure about these options.
The latter should probably be enabled.

I was not sure about these options. The latter should probably be enabled.
konrad commented 2022-04-18 17:16:55 +00:00
Outdated
Review
Copy Link

Does the linter still pass when it is enabled?

Does the linter still pass when it is enabled?
dpschen commented 2022-04-18 20:07:34 +00:00
Outdated
Review
Copy Link

This only affects tslint.
I googled a bit and I think I would use the following:

    "importHelpers": true,
    "sourceMap": true,
    "strictNullChecks": true,
    // "allowJs": true,
    // "allowSyntheticDefaultImports": true,

If we need to we can still use js if we disable the rule for that line.
It seems good to have allowSyntheticDefaultImports disabled

This only affects tslint. I googled a bit and I think I would use the following: ``` "importHelpers": true, "sourceMap": true, "strictNullChecks": true, // "allowJs": true, // "allowSyntheticDefaultImports": true, ``` If we need to we can still use js if we disable the rule for that line. It seems good to have `allowSyntheticDefaultImports` disabled
👍 1
dpschen commented 2022-04-23 11:15:52 +00:00
Outdated
Review
Copy Link

Changed.
Anything else missing for the merge?

Changed. Anything else missing for the merge?
konrad commented 2022-07-04 15:32:26 +00:00
Outdated
Review
Copy Link

I think this should be fine.

I think this should be fine.
// "sourceMap": true,
// "strictNullChecks": true,
"paths": {
"@/*": ["./src/*"]
}