vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix(deps): update vueuse to v9 (major) #2209

Merged
konrad merged 1 commits from renovate/major-vueuse into main 2022-07-31 17:39:54 +00:00
Conversation 1 Commits 1 Files Changed 2 +26 -26
renovate commented 2022-07-31 17:03:25 +00:00
Member
Copy Link

This PR contains the following updates:

Package Type Update Change
@vueuse/core dependencies major 8.9.4 -> 9.0.2
@vueuse/router dependencies major 8.9.4 -> 9.0.2

Release Notes

vueuse/vueuse

v9.0.2

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v9.0.1

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v9.0.0

Compare Source

   🚨 Breaking Changes
   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@vueuse/core](https://github.com/vueuse/vueuse) | dependencies | major | [`8.9.4` -> `9.0.2`](https://renovatebot.com/diffs/npm/@vueuse%2fcore/8.9.4/9.0.2) | | [@vueuse/router](https://github.com/vueuse/vueuse) | dependencies | major | [`8.9.4` -> `9.0.2`](https://renovatebot.com/diffs/npm/@vueuse%2frouter/8.9.4/9.0.2) | --- ### Release Notes <details> <summary>vueuse/vueuse</summary> ### [`v9.0.2`](https://github.com/vueuse/vueuse/releases/tag/v9.0.2) [Compare Source](https://github.com/vueuse/vueuse/compare/v9.0.1...v9.0.2) #####    🐞 Bug Fixes - **nuxt**: Disable auto import for `integrations`  -  by [@&#8203;antfu](https://github.com/antfu) [<samp>(0a43b)</samp>](https://github.com/vueuse/vueuse/commit/0a43b8e9) #####     [View changes on GitHub](https://github.com/vueuse/vueuse/compare/v9.0.1...v9.0.2) ### [`v9.0.1`](https://github.com/vueuse/vueuse/releases/tag/v9.0.1) [Compare Source](https://github.com/vueuse/vueuse/compare/v9.0.0...v9.0.1) #####    🚀 Features - **useDateFormat**: Support dd, ddd and dddd formatter  -  by [@&#8203;aki77](https://github.com/aki77) in https://github.com/vueuse/vueuse/issues/1986 - **useFirestore**: Support reactive query  -  by [@&#8203;kiyopikko](https://github.com/kiyopikko) in https://github.com/vueuse/vueuse/issues/2008 - **useToFixed**: New function  -  by [@&#8203;FliPPeDround](https://github.com/FliPPeDround) in https://github.com/vueuse/vueuse/issues/2003 #####    🐞 Bug Fixes - **useColorMode**: When emitAuto is true, onChanged does not trigger when preferredMode changed  -  by [@&#8203;Waleed-KH](https://github.com/Waleed-KH) in https://github.com/vueuse/vueuse/issues/2004 - **useFetch**: Broken callbacks when RequestInit and UseFetchOptions are both passed in  -  by [@&#8203;curtgrimes](https://github.com/curtgrimes) in https://github.com/vueuse/vueuse/issues/2013 #####     [View changes on GitHub](https://github.com/vueuse/vueuse/compare/v9.0.0...v9.0.1) ### [`v9.0.0`](https://github.com/vueuse/vueuse/releases/tag/v9.0.0) [Compare Source](https://github.com/vueuse/vueuse/compare/v8.9.4...v9.0.0) #####    🚨 Breaking Changes - **all**: `isSupported` becomes `Ref<boolean>` instead of `boolean` for SSR compatibility  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1800 - **all**: Rename function options type with consistant `Use` prefix, huge thanks to [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4)! (this should not affect most of the usage case, unless you are importing those types directly) - <details><summary>All Changes</summary> - **useSpeechSynthesis**: Rename type `Status` to `UseSpeechSynthesisStatus`  -  by [@&#8203;antfu](https://github.com/antfu) [<samp>(db61f)</samp>](https://github.com/vueuse/vueuse/commit/db61fce9) - **onKeyStroke**: Rename type `KeyStrokeOptions` to `OnKeyStrokeOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1807 - **useAsyncState**: Rename type `AsyncStateOptions` to `UseAsyncStateOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1809 - **useClipboard**: Rename type `ClipboardOptions` to `UseClipboardOptions` and `ClipboardReturn` to `UseClipboardReturn`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1861 - **useElementVisibility**: Rename type `VisibilityScrollTargetOptions` to `UseElementVisibilityOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1863 - **useEventSource**: Return type should be `UseEventSourceReturn`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1864 - **useFavicon**: Rename type `FaviconOptions` to `UseFaviconOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1865 - **useFocusWithin**: Rename type `FocusWithinReturn` to `UseFocusWithinReturn`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1866 - **useGeolocation**: Rename type `GeolocationOptions` to `UseGeolocationOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1868 - **useIdle**: Rename type `IdleOptions` to `UseIdleOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1869 - **useIntersectionObserver**: Rename type `IntersectionObserverOptions` to `UseIntersectionObserverOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1870 - **useJwt**: Rename type `JwtOptions` to `UseJwtOptions` and `JwtResult` to `UseJwtReturn`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1899 - **useKeyModifier**: Rename type `ModifierOptions` to `UseModifierOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1871 - **useMagicKeys**: Rename type `MagicKeys` to `UseMagicKeysReturn`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1873 - **useMemoize**: Rename type `UseMemoizedFn` to `UseMemoizeReturn` and new type `UseMemoizeOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1872 - **useMemory**: Rename type `MemoryOptions` to `UseMemoryOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1605 - **useMouse**: Rename type `MouseOptions` to `UseMouseOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1877 - **useMutationObserver**: Rename type `MutationObserverOptions` to `UseMutationObserverOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1884 - **useParallax**: Rename type `ParallaxOptions` to `UseParallaxOptions` and `ParallaxReturn` to `UseParallaxReturn`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1885 - **usePointerSwipe**: Rename type `PointerSwipeOptions` to `UsePointerSwipeOptions` and `PointerSwipeReturn` to `UsePointerSwipeReturn`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1886 - **useRTDB**: Rename type `RTDBOptions` to `UseRTDBOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1901 - **useRafFn**: Rename type `RafFnOptions` to `UseRafFnOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1887 - **useResizeObserver**: Rename type `ResizeObserverOptions` to `UseResizeObserverOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1862 - **useShare**: Rename type `ShareOptions` to `UseShareOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1888 - **useSpeechRecognition**: Rename type `SpeechRecognitionOptions` to `UseSpeechRecognitionOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1889 - **useSpeechSynthesis**: Rename type `SpeechSynthesisOptions` to `UseSpeechSynthesisOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1890 - **useSpeechSynthesis**: Remove `voiceInfo`, allow `voice` as ref  -  by [@&#8203;sibbng](https://github.com/sibbng) in https://github.com/vueuse/vueuse/issues/1882 - **useStorage**: Rename type `StorageOptions` to `UseStorageOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1867 - **useStorageAsync**: Rename type `StorageAsyncOptions` to `UseStorageAsyncOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1883 - **useSwipe**: Rename type `SwipeOptions` to `UseSwipeOptions` and `SwipeReturn` to `UseSwipeReturn`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1891 - **useTimestamp**: Rename type `TimestampOptions` to `UseTimestampOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1892 - **useTransition**: Rename type `TransitionOptions` to `UseTransitionOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1893 - **useVModel**: Rename type `VModelOptions` to `UseVModelOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1894 - **useWebSocket**: Rename type `WebSocketOptions` to `UseWebSocketOptions` and `WebSocketResult` to `UseWebSocketReturn`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1895 - **useWebWorkerFn**: Rename type `WebWorkerOptions` to `UseWebWorkerOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1896 - **useWindowSize**: Rename type `WindowSizeOptions` to `UseWindowSizeOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1897 - **useInterval**: Rename type `IntervalOptions` to `UseIntervalOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1945 - **useIntervalFn**: Rename type `IntervalFnOptions` to `UseIntervalFnOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1943 - **useTimeoutFn,useTimeout**: Rename type `TimeoutOptions` to `UseTimeoutOptions` and `TimeoutFnOptions` to `UseTimeoutFnOptions`  -  by [@&#8203;okxiaoliang4](https://github.com/okxiaoliang4) in https://github.com/vueuse/vueuse/issues/1944 </details> - **firebase**: Support firebase 9 modular  -  by [@&#8203;antfu](https://github.com/antfu) [<samp>(9c65f)</samp>](https://github.com/vueuse/vueuse/commit/9c65fb98) - **math**: Move `logicAnd`, `logicOr`, `logicNot`, `useClamp` to `@vueuse/math`  -  by [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1794, https://github.com/vueuse/vueuse/issues/1810 - **reactify**: Enable support for reactive getter by default  -  by [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1860 - **useThrottleFn**: `trailing` option should be `false` by default  -  by [@&#8203;webfansplz](https://github.com/webfansplz) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1687 - **useMagicKeys**: Store `key` instead of `keyCode` in `current`  -  by [@&#8203;wvffle](https://github.com/wvffle) in https://github.com/vueuse/vueuse/issues/1506 #####    🚀 Features - **all**: Support reactive getter as argument  -  in https://github.com/vueuse/vueuse/issues/1768 This introduces a new convention of passing reactive getters as arguments. Previously, many of VueUse functions supported a convention to accept optional Ref as arguments (`MaybeRef<T>`) to make the reactivity connections. For example: ```ts // pass plain value const title = useTitle('foo') // changes title to 'foo' // pass a ref const myTitle = ref('foo') useTitle(myTitle) // changes title to 'foo' // reactive triggers the update myTitle.value = 'bar' // changes title to 'bar' ``` Since v9.0, most of the VueUse function also accepts a getter function similar to `computed` or the watch source of `watch` to provide better flexibility. ```ts // before const title = computed(() => `${foo.value} | template`) useTitle(title) // with 9.0 useTitle(() => `${foo.value} | template`) ``` It also works great with [Reactivity Transform](https://vuejs.org/guide/extras/reactivity-transform.html). ```ts // before const title = $('foo') useTitle($$(title)) // you need to use $$() to preserve the reactive // with 9.0 const title = $('foo') useTitle(() => title) // you can use a getter function just like `watch` ``` - **math**: New `@vueuse/math` package - **useAbs**: New function  -  by [@&#8203;LittleSound](https://github.com/LittleSound) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1825 - **useCeil**: New function  -  by [@&#8203;webfansplz](https://github.com/webfansplz) in https://github.com/vueuse/vueuse/issues/1818 - **useFloor**: New function  -  by [@&#8203;webfansplz](https://github.com/webfansplz) in https://github.com/vueuse/vueuse/issues/1817 - **useMath**: New function  -  by [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1935 - **useMax**: New function  -  by [@&#8203;FrankFang](https://github.com/FrankFang) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1829 - **useMin**: New function  -  by [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1934 - **useRound**: New function  -  by [@&#8203;webfansplz](https://github.com/webfansplz) in https://github.com/vueuse/vueuse/issues/1820 - **useSum**: New function  -  by [@&#8203;holazz](https://github.com/holazz) in https://github.com/vueuse/vueuse/issues/1837 - **useTrunc**: New function  -  by [@&#8203;hanpei](https://github.com/hanpei) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1838 - **useAverage**: New function  -  by [@&#8203;colgin](https://github.com/colgin) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1826 - New Array-related utilities - **useArrayEvery**: New function  -  by [@&#8203;huynl-96](https://github.com/huynl-96) in https://github.com/vueuse/vueuse/issues/1915 - **useArrayFilter**: New function  -  by [@&#8203;huynl-96](https://github.com/huynl-96) in https://github.com/vueuse/vueuse/issues/1905 - **useArrayFind**: New function  -  by [@&#8203;yjl9903](https://github.com/yjl9903) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1875 - **useArrayJoin**: New function  -  by [@&#8203;huynl-96](https://github.com/huynl-96) in https://github.com/vueuse/vueuse/issues/1904 - **useArrayMap**: New function  -  by [@&#8203;huynl-96](https://github.com/huynl-96) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1908 - **useArrayReduce**: New function  -  by [@&#8203;yjl9903](https://github.com/yjl9903) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1919 - **useArraySome**: New function  -  by [@&#8203;huynl-96](https://github.com/huynl-96) in https://github.com/vueuse/vueuse/issues/1916 - **useArrayFindIndex**: New function  -  by [@&#8203;huynl-96](https://github.com/huynl-96) in https://github.com/vueuse/vueuse/issues/1973 - **syncRef**: Support custom transforms  -  by [@&#8203;chaii3](https://github.com/chaii3) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1968 - **useAsyncState**: Add `throwError` option  -  by [@&#8203;TuiMao233](https://github.com/TuiMao233) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1975 - **useColorMode**: New `initialValue` option  -  by [@&#8203;antfu](https://github.com/antfu) [<samp>(fcaf9)</samp>](https://github.com/vueuse/vueuse/commit/fcaf9509) - **useStorage**: `mergeDefaults` option  -  by [@&#8203;webfansplz](https://github.com/webfansplz) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1957 - **useTextDirection**: New function  -  by [@&#8203;iChengbo](https://github.com/iChengbo) and [@&#8203;antfu](https://github.com/antfu) in https://github.com/vueuse/vueuse/issues/1678 #####    🐞 Bug Fixes - **nuxt**: Support import submodules for `@vueuse/integrations`  -  by [@&#8203;antfu](https://github.com/antfu) [<samp>(18ba0)</samp>](https://github.com/vueuse/vueuse/commit/18ba05ea) - **onClickOutside**: Fix handler type  -  by [@&#8203;sibbng](https://github.com/sibbng) in https://github.com/vueuse/vueuse/issues/1961 - **useOffsetPagination**: Incorrectly `currentPageSize` value  -  by [@&#8203;webfansplz](https://github.com/webfansplz) in https://github.com/vueuse/vueuse/issues/1949 - **useSpeechSynthesis**: Remove duplicated `onend`, fix demo  -  by [@&#8203;sibbng](https://github.com/sibbng) in https://github.com/vueuse/vueuse/issues/1941 - **useWebSocket**: Set initial status as `CLOSED`  -  by [@&#8203;chaii3](https://github.com/chaii3) in https://github.com/vueuse/vueuse/issues/1960 - **useNProgress**: Improve SSR support  -  by [@&#8203;webfansplz](https://github.com/webfansplz) in https://github.com/vueuse/vueuse/issues/1990 #####     [View changes on GitHub](https://github.com/vueuse/vueuse/compare/v8.9.4...v9.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
renovate added the
dependencies
 label 2022-07-31 17:03:25 +00:00
renovate added 1 commit 2022-07-31 17:03:26 +00:00
continuous-integration/drone/pr Build is passing Details
a1e819589a fix(deps): update vueuse to v9
konrad scheduled this pull request to auto merge when all checks succeed 2022-07-31 17:11:51 +00:00
frederick commented 2022-07-31 17:32:21 +00:00
Member
Copy Link

Hi renovate!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2209-renovate-major-vueuse--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi renovate! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2209-renovate-major-vueuse--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad merged commit ce7563ea4c into main 2022-07-31 17:39:54 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2209
No description provided.
Delete Branch "renovate/major-vueuse"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?