vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: allow marking a related task done directly from the list of related tasks #2330

Closed
konrad wants to merge 3 commits from feature/enable-related-task-done into main
pull from: feature/enable-related-task-done
merge into: vikunja:main
Conversation 5 Commits 3 Files Changed 5 +40 -19
konrad commented 2022-09-07 15:47:43 +00:00
Owner
Copy Link

Related forum thread: https://community.vikunja.io/t/task-checklists/680/11?u=kolaente

There is one caveat remaining: If the user does not have the right to mark the related task as done an error message will be shown and the task won't be marked as done. Currently the api does not provide a way for us to check this in advance (without loading each task individually) so we can't really prevent this.

Related forum thread: https://community.vikunja.io/t/task-checklists/680/11?u=kolaente There is one caveat remaining: If the user does not have the right to mark the related task as done an error message will be shown and the task won't be marked as done. Currently the api does not provide a way for us to check this in advance (without loading each task individually) so we can't really prevent this.
dpschen was assigned by konrad 2022-09-07 15:47:44 +00:00
konrad requested review from dpschen 2022-09-07 15:49:16 +00:00
frederick commented 2022-09-07 15:50:30 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2330-feature-enable-related-task-done--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2330-feature-enable-related-task-done--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad changed title from feat: allow marking a related task done directly from the list to feat: allow marking a related task done directly from the list of related tasks 2022-09-07 17:55:39 +00:00
dpschen commented 2022-09-08 09:56:56 +00:00
Member
Copy Link

I would love if we could fix the related task script setup and apply this to that pull request.

I would love if we could fix the related task script setup and apply this to that pull request.
dpschen reviewed 2022-09-08 09:58:46 +00:00
src/components/tasks/partials/relatedTasks.vue Outdated
@ -317,0 +324,4 @@
async toggleTaskDone(task: ITask) {
if (task.done) {
playPop()
dpschen commented 2022-09-08 09:58:46 +00:00
Member

Unsure: Wouldn't it make sense to play this from the store when we update the task an the done prop has changed?

Unsure: Wouldn't it make sense to play this from the store when we update the task an the `done` prop has changed?
konrad commented 2022-09-08 11:47:49 +00:00
Author
Owner

Yes.

Yes.
konrad commented 2022-09-08 11:52:06 +00:00
Author
Owner

Done.

Done.
👍 1
konrad marked this conversation as resolved
dpschen reviewed 2022-09-08 10:00:06 +00:00
src/components/tasks/partials/relatedTasks.vue Outdated
@ -389,1 +415,4 @@
.task-done-checkbox {
padding: 0;
height: 18px; // The exact height of the checkbox in the container
dpschen commented 2022-09-08 10:00:06 +00:00
Member

Why do we need to set a height from outside here?

Why do we need to set a height from outside here?
konrad commented 2022-09-08 11:46:14 +00:00
Author
Owner

Because otherwise the height of the actual checkbox in the <Fancycheckbox component is too much resulting in a weired positioning of the checkbox. Setting the height here is a workaround until we fix the styling of the component. I didn't want to do this in this PR because the component is used in a lot of places and the change has potential to break a few things. Better do it in another PR.

Because otherwise the height of the actual checkbox in the `<Fancycheckbox` component is too much resulting in a weired positioning of the checkbox. Setting the height here is a workaround until we fix the styling of the component. I didn't want to do this in this PR because the component is used in a lot of places and the change has potential to break a few things. Better do it in another PR.
dpschen commented 2022-09-08 14:57:22 +00:00
Member

Okay. Can you prefix it with a // FIXME: or // HACK: then?

Okay. Can you prefix it with a `// FIXME:` or `// HACK:` then?
konrad commented 2022-09-13 19:56:19 +00:00
Author
Owner

Done.

Done.
👍 1
konrad marked this conversation as resolved
konrad commented 2022-09-08 11:47:28 +00:00
Author
Owner
Copy Link

I would love if we could fix the related task script setup and apply this to that pull request.

Ohh right we also have that open! I think we should merge the other one first.

> I would love if we could fix the related task script setup and apply this to that pull request. Ohh right we also have that open! I think we should merge the other one first.
👍 1
konrad force-pushed feature/enable-related-task-done from 1ffcd5ff2f to f24ac01e36 2022-09-08 11:51:57 +00:00 Compare
dpschen requested changes 2022-09-08 17:31:35 +00:00
dpschen left a comment
Member

#2330 (comment)

https://kolaente.dev/vikunja/frontend/pulls/2330#issuecomment-34972
konrad added 1 commit 2022-09-13 19:56:17 +00:00
continuous-integration/drone/pr Build is passing Details
3f16d17cef
chore: add FIXME
konrad requested review from dpschen 2022-09-14 16:42:04 +00:00
dpschen commented 2022-09-15 20:43:51 +00:00
Member
Copy Link

I ported this over to #1939 in 08dc289260

I ported this over to https://kolaente.dev/vikunja/frontend/pulls/1939 in https://kolaente.dev/vikunja/frontend/commit/08dc28926008b5539223f8d2878ac5b40a2565d0
konrad commented 2022-09-15 20:44:27 +00:00
Author
Owner
Copy Link

So we'll close this one in favour of #1939?

So we'll close this one in favour of #1939?
👍 1
dpschen closed this pull request 2022-09-20 16:58:38 +00:00
dpschen refused to review 2022-09-20 16:58:43 +00:00
dpschen removed their assignment 2022-09-20 16:58:48 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2330
No description provided.
Delete Branch "feature/enable-related-task-done"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?