vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

WIP: feat: add default reminder for tasks with a due date #2360

Draft
konrad wants to merge 17 commits from feature/add-default-reminder into main
pull from: feature/add-default-reminder
merge into: vikunja:main
Conversation 2 Commits 17 Files Changed 12 +3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8baafab456 - Show all commits

3
src/views/tasks/TaskDetailView.vue
View File

@ -697,6 +697,9 @@ export default defineComponent({
}
this.task = await this.$store.dispatch('tasks/update', task)
// Activate new fields which may have been set from the api
this.$nextTick(() => this.setActiveFields())
dpschen commented 2022-09-29 18:38:49 +00:00
Review
Copy Link

I don't understand why the nextTick is necessary here.

I don't understand why the nextTick is necessary here.
konrad commented 2022-09-30 11:30:31 +00:00
Review
Copy Link

The comment is wrong but the tick is required to make sure the maybe newly set reminder would be shown in the task detail view as well. I'll clarify the comment.

The comment is wrong but the tick is required to make sure the maybe newly set reminder would be shown in the task detail view as well. I'll clarify the comment.
👍 1
if (!showNotification) {
return