vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

WIP: feat: add default reminder for tasks with a due date #2360

Draft
konrad wants to merge 17 commits from feature/add-default-reminder into main
pull from: feature/add-default-reminder
merge into: vikunja:main
Conversation 2 Commits 17 Files Changed 12 -1
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ad2644edf8 - Show all commits

1
src/views/user/settings/General.vue
View File

@ -321,7 +321,6 @@ async function updateSettings() {
const reminderSettings = getSavedReminderSettings()
const defaultReminderEnabled = ref<boolean>(reminderSettings?.enabled || false)
// TODO: re-populate amount and type
const defaultReminderAmount = ref(reminderSettings?.amount || 1)
const defaultReminderAmountType = ref(reminderSettings?.type || 'days')
konrad marked this conversation as resolved
dpschen commented 2022-09-29 18:40:24 +00:00
Review
Copy Link

Shouldn't the fallback be the same as the default in the model?

Shouldn't the fallback be the same as the default in the model?
konrad commented 2022-09-30 11:32:42 +00:00
Review
Copy Link

Actually not, because this is what gets shown in the input when setting this for the first time. I felt like putting a 0 here would feel weired.

Actually not, because this is what gets shown in the input when setting this for the first time. I felt like putting a `0` here would feel weired.
</script>