vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

WIP: feat: add default reminder for tasks with a due date #2360

Draft
konrad wants to merge 17 commits from feature/add-default-reminder into main
pull from: feature/add-default-reminder
merge into: vikunja:main
Conversation 2 Commits 17 Files Changed 12 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d5bc1cd1d6 - Show all commits

2
src/helpers/defaultReminder.ts
View File

@ -10,7 +10,7 @@ export const AMOUNTS_IN_SECONDS: {
hours: 60 * 60,
days: 60 * 60 * 24,
months: 60 * 60 * 24 * 30,
}
} as const
konrad marked this conversation as resolved Outdated
dpschen commented 2022-09-29 18:29:06 +00:00
Outdated
Review
Copy Link

Add as const

Add `as const`
konrad commented 2022-09-30 11:28:17 +00:00
Outdated
Review
Copy Link

Done.

Done.
interface DefaultReminderSettings {
enabled: boolean,
konrad marked this conversation as resolved Outdated
dpschen commented 2022-09-14 14:21:23 +00:00
Outdated
Review
Copy Link

We should save the factors in array in a mapping constant. This way the constant can be reused for the test.

We should save the factors in array in a mapping constant. This way the constant can be reused for the test.
konrad commented 2022-09-29 16:23:12 +00:00
Outdated
Review
Copy Link

Done.

Done.