vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

WIP: feat: add default reminder for tasks with a due date #2360

Draft
konrad wants to merge 17 commits from feature/add-default-reminder into main
pull from: feature/add-default-reminder
merge into: vikunja:main
Conversation 2 Commits 17 Files Changed 12 +7 -8
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e623954351 - Show all commits

15
src/helpers/defaultReminder.ts
View File

@ -1,10 +1,7 @@
const DEFAULT_REMINDER_KEY = 'defaultReminder'
export const AMOUNTS_IN_SECONDS: {
konrad marked this conversation as resolved
dpschen commented 2022-09-29 18:28:09 +00:00
Review
Copy Link

Reuse type definition. E.g.

{ [type in SavedReminderSettings['type']]: number }
Reuse type definition. E.g. ```ts { [type in SavedReminderSettings['type']]: number } ```
konrad commented 2022-09-30 11:28:07 +00:00
Review
Copy Link

Done.

Done.
minutes: number,
hours: number,
days: number,
months: number,
[type in SavedReminderSettings['type']]: number
} = {
minutes: 60,
hours: 60 * 60,
@ -19,15 +16,15 @@ interface DefaultReminderSettings {
konrad marked this conversation as resolved Outdated
dpschen commented 2022-09-14 14:21:23 +00:00
Outdated
Review
Copy Link

We should save the factors in array in a mapping constant. This way the constant can be reused for the test.

We should save the factors in array in a mapping constant. This way the constant can be reused for the test.
konrad commented 2022-09-29 16:23:12 +00:00
Outdated
Review
Copy Link

Done.

Done.
interface SavedReminderSettings {
enabled: boolean,
amount?: number,
type?: 'minutes' | 'hours' | 'days' | 'months',
amount: number,
type: 'minutes' | 'hours' | 'days' | 'months',
}
function calculateDefaultReminderSeconds(type: string, amount: number): number {
function calculateDefaultReminderSeconds(type: SavedReminderSettings['type'], amount: number): number {
return amount * (AMOUNTS_IN_SECONDS[type] || 0)
}
konrad marked this conversation as resolved
dpschen commented 2022-09-29 18:32:21 +00:00
Review
Copy Link

type would better be as keyof typeof AMOUNT_IN_SECONDS.

Maybe we should save the type as new type, e.g.

type IReminderDurationType = 'minutes' | 'hours' | 'days' | 'months'
`type` would better be as `keyof typeof AMOUNT_IN_SECONDS`. Maybe we should save the `type` as new type, e.g. ```ts type IReminderDurationType = 'minutes' | 'hours' | 'days' | 'months' ```
konrad commented 2022-09-30 11:27:55 +00:00
Review
Copy Link

I've changed it to use SavedReminderSettings['type'] instead.

I've changed it to use `SavedReminderSettings['type']` instead.
export function saveDefaultReminder(enabled: boolean, type: string, amount: number) {
export function saveDefaultReminder(enabled: boolean, type: SavedReminderSettings['type'], amount: number) {
const defaultReminderSeconds = calculateDefaultReminderSeconds(type, amount)
localStorage.setItem(DEFAULT_REMINDER_KEY, JSON.stringify(<DefaultReminderSettings>{
enabled,
@ -83,6 +80,8 @@ export function getSavedReminderSettings(): SavedReminderSettings | null {
if (!s.enabled) {
return {
enabled: false,
type: 'minutes',
amount: 0,
}
}