vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/feat-pinia-list-store | pinia 2/9 #2392

Merged
konrad merged 2 commits from dpschen/frontend:feature/feat-pinia-list-store into main 2022-09-21 16:21:27 +00:00
Conversation 1 Commits 2 Files Changed 23 +272 -239
dpschen commented 2022-09-20 23:52:44 +00:00
Member
Copy Link
No description provided.
dpschen added 1 commit 2022-09-20 23:52:45 +00:00
dpschen added the
kind/feature
 label 2022-09-20 23:52:51 +00:00
frederick commented 2022-09-20 23:59:11 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2392-feature-feat-pinia-list-store--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2392-feature-feat-pinia-list-store--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from WIP: feature/feat-pinia-list-store to WIP: feature/feat-pinia-list-store | pinia 2/9 2022-09-21 09:28:43 +00:00
dpschen force-pushed feature/feat-pinia-list-store from fce264cac9 to eb2c5e3aba 2022-09-21 10:27:06 +00:00 Compare
dpschen changed title from WIP: feature/feat-pinia-list-store | pinia 2/9 to feature/feat-pinia-list-store | pinia 2/9 2022-09-21 11:39:03 +00:00
dpschen requested review from konrad 2022-09-21 11:39:08 +00:00
konrad was assigned by dpschen 2022-09-21 11:39:12 +00:00
dpschen added 1 commit 2022-09-21 11:39:44 +00:00
continuous-integration/drone/pr Build is passing Details
3502a3f4c1
feat: port label store to pinia
dpschen added 2 commits 2022-09-21 15:12:22 +00:00
continuous-integration/drone/pr Build is passing Details
1266da8f0b
feat: port list store to pinia
konrad reviewed 2022-09-21 16:20:45 +00:00
src/stores/lists.ts
@ -0,0 +153,4 @@
},
})
export function useList(listId: MaybeRef<ListModel['id']>) {
konrad commented 2022-09-21 16:20:45 +00:00
Owner

Where is this actually used?

Where is this actually used?
dpschen commented 2022-09-21 16:22:50 +00:00
Author
Member

Currently only in list settings edit.
But I might create something based on this in the future (combined with zod).

Currently only in list settings edit. But I might create something based on this in the future (combined with zod).
👍 1
konrad approved these changes 2022-09-21 16:20:49 +00:00
konrad merged commit a38075f376 into main 2022-09-21 16:21:27 +00:00
konrad deleted branch feature/feat-pinia-list-store 2022-09-21 16:21:27 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2392
No description provided.
Delete Branch "dpschen/frontend:feature/feat-pinia-list-store"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?