feature/feat-pinia-task-store | pinia 7/9 #2409
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#2409
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/feat-pinia-task-store"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
b356809c60
to6132a85251
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://2409-feature-feat-pinia-task-store--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
6f99b642e9
to0255a44032
WIP: feature/feat-pinia-task-store | pinia 7/9to feature/feat-pinia-task-store | pinia 7/9Can you rebase this?
@konrad: done
@ -75,2 +76,3 @@
const store = useStore()
const loading = computed(() => store.state.loading)
const taskStore = useTaskStore()
const loading = computed(() => store.state.loading) // FIXME: shouldn't this reference the taskStores loading state?
It should use the task store's loading state. Mabye something like
computed(() => store.state.loading || taskStore.loading)
?Wouldn't the taskStores loading state be enough now?
I did now only:
I think that should be fine, yes.
@ -0,0 +8,4 @@
import UserService from '@/services/user'
import {HAS_TASKS} from '../store/mutation-types'
import {setLoadingPinia} from '../store/helper'
Can you use
@
here for the imports?I left that for
34b9b2a315 (diff-ab7455b2612e9ac43f45f7bb8a4bf872e2e6b171)
since I remove the store there completelywell looks like I need to always put a comment here now