feat: editor script setup #2470

dpschen · 2022-10-03T10:19:48Z

dpschen commented

2022-10-03 10:19:48 +00:00

Since the tiptap integration might still take I while I wanted to completely finish our typescript / script setup migration.

👍 1

dpschen added the

area/internal-code

label 2022-10-03 10:19:48 +00:00

dpschen reviewed 2022-10-03 10:20:37 +00:00

src/helpers/randomId.ts Outdated

						
				@ -2,3 +2,3 @@

				export function createRandomID(idLength = DEFAULT_ID_LENGTH) {

					return Math.random().toString(36).substr(2, idLength)

					return Math.random().toString(36).slice(2, idLength)

dpschen commented

2022-10-03 10:20:37 +00:00

substr is deprecated thus all the replacements with slice

`substr` is deprecated thus all the replacements with `slice`

👍 1

dpschen force-pushed feature/feat-editor-script-setup from ed188bafee to 2fcdbf794c

2022-10-03 10:22:46 +00:00

Compare

frederick commented

2022-10-03 10:25:58 +00:00

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2470-feature-feat-editor-script-setup--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2470-feature-feat-editor-script-setup--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen changed title from ~~WIP: feat: editor script setup~~ to feat: editor script setup

2022-10-03 16:14:35 +00:00

dpschen requested review from konrad 2022-10-03 16:14:49 +00:00

konrad was assigned by dpschen

2022-10-03 16:14:53 +00:00

konrad reviewed 2022-10-03 20:23:05 +00:00

konrad left a comment

Ready to merge once rebased.

konrad approved these changes 2022-10-03 20:23:16 +00:00

dpschen force-pushed feature/feat-editor-script-setup from 2fcdbf794c to db627ed28a

2022-10-04 07:42:10 +00:00

Compare