vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/improve-drone-config #2637

Merged
konrad merged 5 commits from dpschen/frontend:feature/improve-drone-config into main 2022-11-08 14:56:46 +00:00
Conversation 6 Commits 5 Files Changed 1 +30 -28
1 changed files with 30 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
.drone.yml
View File

@ -1,5 +1,6 @@
---
kind: pipeline
type: docker
dpschen marked this conversation as resolved Outdated
dpschen commented 2022-11-05 16:01:29 +00:00
Outdated
Review
Copy Link

Is docker the default? I was unsure here, but my drone linter in vscode told me that not declaring a type is also wrong.

Is `docker` the default? I was unsure here, but my drone linter in vscode told me that not declaring a type is also wrong.
konrad commented 2022-11-07 11:56:55 +00:00
Outdated
Review
Copy Link

Docker is the default, yes.

Docker is the default, yes.
👍 1
name: build
trigger:
@ -22,7 +23,7 @@ steps:
# Disabled until we figure out why it is so slow
# - name: restore-cache
# image: meltwater/drone-cache:dev
# pull: true
# pull: always
# environment:
# AWS_ACCESS_KEY_ID:
# from_secret: cache_aws_access_key_id
@ -41,7 +42,7 @@ steps:
- name: dependencies
image: node:18-alpine
pull: true
pull: always
dpschen commented 2022-11-05 16:02:20 +00:00
Outdated
Review
Copy Link

I forgot (and couldn't find out) if always is the default value either way. If so we could also remove the pull property.

I forgot (and couldn't find out) if `always` is the default value either way. If so we could also remove the `pull` property.
👍 1
dpschen commented 2022-11-07 12:51:09 +00:00
Outdated
Review
Copy Link

Do you know where to find the default config of drone?

Do you know where to find the default config of drone?
konrad commented 2022-11-07 13:00:51 +00:00
Outdated
Review
Copy Link

There's a reference somewhere.

I think for this particular case this is the relevant part of the docs: https://docs.drone.io/pipeline/kubernetes/syntax/images/#pulling-images

There's a reference somewhere. I think for this particular case this is the relevant part of the docs: https://docs.drone.io/pipeline/kubernetes/syntax/images/#pulling-images
dpschen commented 2022-11-07 13:44:24 +00:00
Outdated
Review
Copy Link

Yes, sadly they don't mention the default setting.

Yes, sadly they don't mention the default setting.
konrad commented 2022-11-07 14:05:00 +00:00
Outdated
Review
Copy Link

But they say:

If the image is tagged with latest, Drone will always attempt to pull the latest version of the image. Configure the runner to only pull the image if not found in the local cache:

But they say: > If the image is tagged with latest, Drone will always attempt to pull the latest version of the image. Configure the runner to only pull the image if not found in the local cache:
dpschen commented 2022-11-07 14:22:51 +00:00
Outdated
Review
Copy Link

Ahh, and ours are tagged with latest, so it will pull the latest anyway?

Ahh, and ours are tagged with latest, so it will pull the latest anyway?
konrad commented 2022-11-07 14:27:24 +00:00
Outdated
Review
Copy Link

This particular one has a tag of 18-alpine so it won't pull it always.

This particular one has a tag of `18-alpine` so it won't pull it always.
environment:
PNPM_CACHE_FOLDER: .cache/pnpm
CYPRESS_CACHE_FOLDER: .cache/cypress
@ -53,7 +54,7 @@ steps:
- name: lint
image: node:18-alpine
pull: true
pull: always
environment:
PNPM_CACHE_FOLDER: .cache/pnpm
commands:
@ -64,7 +65,7 @@ steps:
- name: build-prod
image: node:18-alpine
pull: true
pull: always
environment:
PNPM_CACHE_FOLDER: .cache/pnpm
commands:
@ -75,7 +76,7 @@ steps:
- name: test-unit
image: node:18-alpine
pull: true
pull: always
commands:
- corepack enable && pnpm config set store-dir .cache/pnpm
- pnpm run test:unit
@ -85,7 +86,7 @@ steps:
- name: typecheck
failure: ignore
image: node:18-alpine
pull: true
pull: always
environment:
PNPM_CACHE_FOLDER: .cache/pnpm
commands:
@ -95,8 +96,8 @@ steps:
- dependencies
- name: test-frontend
image: cypress/browsers:node16.14.0-chrome99-ff97
pull: true
image: cypress/browsers:node18.12.0-chrome106-ff106
pull: always
environment:
CYPRESS_API_URL: http://api:3456/api/v1
CYPRESS_TEST_SECRET: averyLongSecretToSe33dtheDB
@ -116,7 +117,7 @@ steps:
# - name: rebuild-cache
# image: meltwater/drone-cache:dev
# pull: true
# pull: always
# environment:
# AWS_ACCESS_KEY_ID:
# from_secret: cache_aws_access_key_id
@ -136,7 +137,7 @@ steps:
- name: deploy-preview
image: node:18-alpine
pull: true
pull: always
environment:
NETLIFY_AUTH_TOKEN:
from_secret: netlify_auth_token
@ -160,6 +161,7 @@ steps:
---
kind: pipeline
type: docker
name: release-latest
depends_on:
@ -179,7 +181,7 @@ steps:
# - name: restore-cache
# image: meltwater/drone-cache:dev
# pull: true
# pull: always
# environment:
# AWS_ACCESS_KEY_ID:
# from_secret: cache_aws_access_key_id
@ -197,13 +199,12 @@ steps:
- name: build
image: node:18-alpine
pull: true
group: build-static
dpschen marked this conversation as resolved Outdated
dpschen commented 2022-11-05 16:03:51 +00:00
Outdated
Review
Copy Link

A group property doesn't seem to exist in drone.

A `group` property doesn't seem to exist in drone.
konrad commented 2022-11-07 12:00:54 +00:00
Outdated
Review
Copy Link

That's probably a relic from Drone 1

That's probably a relic from Drone 1
👍 1
pull: always
environment:
PNPM_CACHE_FOLDER: .cache/pnpm
commands:
- apk add git
- corepack enable && pnpm config set store-dir .cache/.pnp
- corepack enable && pnpm config set store-dir .cache/.pnpm
dpschen marked this conversation as resolved Outdated
dpschen commented 2022-11-05 16:03:00 +00:00
Outdated
Review
Copy Link

This cache folder was wrong. Maybe this decreases our build time?

This cache folder was wrong. Maybe this decreases our build time?
👍 1
- pnpm install --fetch-timeout 100000 --frozen-lockfile
- pnpm run lint
- "echo '{\"VERSION\": \"'$(git describe --tags --always --abbrev=10 | sed 's/-/+/' | sed 's/^v//' | sed 's/-g/-/')'\"}' > src/version.json"
@ -214,7 +215,7 @@ steps:
- name: static
image: kolaente/zip
pull: true
pull: always
commands:
- cd dist
- zip -r ../vikunja-frontend-unstable.zip *
@ -223,7 +224,7 @@ steps:
- name: release
image: plugins/s3
pull: true
pull: always
settings:
bucket: vikunja-releases
access_key:
@ -239,6 +240,7 @@ steps:
---
kind: pipeline
type: docker
name: release-version
depends_on:
@ -256,7 +258,7 @@ steps:
# - name: restore-cache
# image: meltwater/drone-cache:dev
# pull: true
# pull: always
# environment:
# AWS_ACCESS_KEY_ID:
# from_secret: cache_aws_access_key_id
@ -274,8 +276,7 @@ steps:
- name: build
image: node:18-alpine
pull: true
group: build-static
pull: always
environment:
PNPM_CACHE_FOLDER: .cache/pnpm
commands:
@ -291,7 +292,7 @@ steps:
- name: static
image: kolaente/zip
pull: true
pull: always
commands:
- cd dist
- zip -r ../vikunja-frontend-${DRONE_TAG##v}.zip *
@ -300,7 +301,7 @@ steps:
- name: release
image: plugins/s3
pull: true
pull: always
settings:
bucket: vikunja-releases
access_key:
@ -316,6 +317,7 @@ steps:
---
kind: pipeline
type: docker
name: trigger-desktop-update
trigger:
@ -361,7 +363,7 @@ trigger:
steps:
- name: docker-unstable
image: plugins/docker:linux-arm
pull: true
pull: always
settings:
username:
from_secret: docker_username
@ -380,7 +382,7 @@ steps:
- name: docker-version
image: plugins/docker:linux-arm
pull: true
pull: always
settings:
username:
from_secret: docker_username
@ -400,7 +402,7 @@ steps:
- name: docker-unstable-arm64
image: plugins/docker:linux-arm64
pull: true
pull: always
settings:
username:
from_secret: docker_username
@ -419,7 +421,7 @@ steps:
- name: docker-version-arm64
image: plugins/docker:linux-arm64
pull: true
pull: always
settings:
username:
from_secret: docker_username
@ -461,7 +463,7 @@ trigger:
steps:
- name: docker-unstable
image: plugins/docker:linux-amd64
pull: true
pull: always
settings:
username:
from_secret: docker_username
@ -478,7 +480,7 @@ steps:
- name: docker-version
image: plugins/docker:linux-amd64
pull: true
pull: always
settings:
username:
from_secret: docker_username
@ -661,6 +663,6 @@ steps:
from_secret: crowdin_key
---
kind: signature
hmac: 5dc7ab785b6e4d1611fc2851971e23c444d93d4988517f116e02e8c4d1af82f3
hmac: 6784e836f6568c67abfb909449c6e845cc73cbe9a31e9e7ad9166a0eb59e30a2
...