vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: ListKanban script setup #2643

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-ListKanban-script-setup into main 2022-11-07 17:23:13 +00:00
Conversation 1 Commits 1 Files Changed 7 +391 -418
dpschen commented 2022-11-07 11:15:48 +00:00
Member
Copy Link

Changes from #1571 were to hard to rebase with all the changes in between.
This is a new conversion on which I want to add the chagnes of the latter branch manually on top

Changes from https://kolaente.dev/vikunja/frontend/pulls/1571 were to hard to rebase with all the changes in between. This is a new conversion on which I want to add the chagnes of the latter branch manually on top
dpschen added the
kind/feature
area/internal-code
 labels 2022-11-07 11:15:48 +00:00
dpschen force-pushed feature/feat-ListKanban-script-setup from 2cc78f54b0 to 22f2e31bd1 2022-11-07 11:24:25 +00:00 Compare
frederick commented 2022-11-07 11:29:13 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2643-feature-feat-listkanban-script-s--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2643-feature-feat-listkanban-script-s--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/feat-ListKanban-script-setup from 22f2e31bd1 to abce057598 2022-11-07 12:00:15 +00:00 Compare
dpschen changed title from WIP: feat: ListKanban script setup to feat: ListKanban script setup 2022-11-07 12:00:26 +00:00
dpschen requested review from konrad 2022-11-07 12:00:30 +00:00
konrad was assigned by dpschen 2022-11-07 12:00:33 +00:00
dpschen force-pushed feature/feat-ListKanban-script-setup from abce057598 to ce3b72966d 2022-11-07 13:41:24 +00:00 Compare
konrad requested changes 2022-11-07 14:02:20 +00:00
src/views/list/ListKanban.vue
@ -3,2 +6,3 @@
>
<template #header>
<div class="filter-container" v-if="!isSavedFilter(listId)">
<div class="filter-container" v-if="!isSavedFilter(list)">
konrad commented 2022-11-07 13:58:17 +00:00
Owner

Shouldn't this use the listId?

Shouldn't this use the `listId`?
dpschen commented 2022-11-07 14:27:39 +00:00
Author
Member

Currently it wants the list. Typescript helped to find this :)

Maybe we should refactor it to something like isSavedFilterById.

Currently [it wants the list](https://kolaente.dev/vikunja/frontend/src/branch/main/src/services/savedFilter.ts#L41). Typescript helped to find this :) Maybe we should refactor it to something like `isSavedFilterById`.
konrad commented 2022-11-07 14:28:06 +00:00
Owner

Refactoring this sounds like a good idea.

Refactoring this sounds like a good idea.
konrad commented 2022-11-07 14:28:25 +00:00
Owner

Or don't refactor it, this was just something I stumbled upon.

Or don't refactor it, this was just something I stumbled upon.
👍 1
src/views/list/ListKanban.vue
@ -577,3 +537,1 @@
if (limit < 0) {
return
}
// TODO: fix type
konrad commented 2022-11-07 14:02:00 +00:00
Owner

What type should be used here?

What type should be used here?
dpschen commented 2022-11-07 14:29:44 +00:00
Author
Member

This was intended for the short future when I apply the changes of #1571 on top of this branch.

This was intended for the short future when I apply the changes of https://kolaente.dev/vikunja/frontend/pulls/1571 on top of this branch.
👍 1
konrad commented 2022-11-07 14:34:00 +00:00
Owner

Should be fine then.

Should be fine then.
konrad merged commit d85abbd77a into main 2022-11-07 17:23:13 +00:00
konrad deleted branch feature/feat-ListKanban-script-setup 2022-11-07 17:23:14 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2643
No description provided.
Delete Branch "dpschen/frontend:feature/feat-ListKanban-script-setup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?