vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix(postcss-preset-env): client side polyfills #3051

Merged
konrad merged 1 commits from dpschen/frontend:fix-postcss-preset-env-client-side-polyfills into main 2023-02-15 15:40:02 +00:00
Conversation 1 Commits 1 Files Changed 1 +11 -1
dpschen commented 2023-02-02 17:01:04 +00:00
Member
Copy Link
No description provided.
dpschen added the
kind/bug
area/internal-code
 labels 2023-02-02 17:01:04 +00:00
konrad was assigned by dpschen 2023-02-02 17:01:04 +00:00
dpschen reviewed 2023-02-02 17:05:54 +00:00
vite.config.ts Outdated
@ -69,0 +71,4 @@
// get a better browser support:
// https://github.com/csstools/postcss-plugins/tree/main/plugin-packs/postcss-preset-env#plugins-that-need-client-library
// see also './src/polyfills.ts'
enableClientSidePolyfills: true,
dpschen commented 2023-02-02 17:05:54 +00:00
Author
Member

Now that I enabled the former default again, I'm unsure if I would need to disable the other plugins again as well.

Now that I enabled the former default again, I'm unsure if I would need to disable [the other plugins](https://kolaente.dev/vikunja/frontend/src/commit/489014944a1544846875910d7d5e17e3d71b7e2d/vite.config.ts#L69-L77) again as well.
dpschen commented 2023-02-02 17:12:49 +00:00
Author
Member

Maybe it's also enough to do the opposite: force enable the focus-visible-pseudo-class plugin like this:

features: {
    'focus-within-pseudo-class': true,
},

AFAIK 'focus-visible-pseudo-class' is the only feature of those plugins that require a client side polyfill that we use.

When I read the documentation of that plugin I get a bit confused though if we even need that src/polyfills.ts file or if enabling that plugin should be enought for the client side polyfill to be included. See that sentence:

PostCSS Focus Within works in all major browsers, including Safari 6+ and Internet Explorer 9+ without any additional polyfills.

Source: https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-focus-within#browser

Really confusing that documentation!

Maybe it's also enough to do the opposite: force enable the focus-visible-pseudo-class plugin like this: ```js features: { 'focus-within-pseudo-class': true, }, ``` AFAIK 'focus-visible-pseudo-class' is the only feature of those plugins that require a client side polyfill that we use. When I read [the documentation of that plugin](https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-focus-within) I get a bit confused though if we even need that `src/polyfills.ts` file or if enabling that plugin should be enought for the client side polyfill to be included. See that sentence: > PostCSS Focus Within works in all major browsers, including Safari 6+ and Internet Explorer 9+ without any additional polyfills. _Source: https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-focus-within#browser_ Really confusing that documentation!
konrad commented 2023-02-02 21:13:22 +00:00
Owner

If it's possible to enable the polyfill only for that specific feature I think that's a good idea. Or is the rest tree-shaked?

See that sentence:

That sounds like it does not need a polyfill at all? (When targeting newer browsers than these)

If it's possible to enable the polyfill only for that specific feature I think that's a good idea. Or is the rest tree-shaked? > See that sentence: That sounds like it does not need a polyfill at all? (When targeting newer browsers than these)
dpschen commented 2023-02-08 12:15:40 +00:00
Author
Member

Or is the rest tree-shaked?

I'm unsure.

It's also very time-consuming to test this since I would need to pick a browser version in browserslist that doesn't support those features natively.

Should I try the variant where I only enable features?

> Or is the rest tree-shaked? I'm unsure. It's also very time-consuming to test this since I would need to pick a browser version in browserslist that doesn't support those features natively. Should I try the variant where I only enable features?
konrad commented 2023-02-09 21:46:06 +00:00
Owner

Should I try the variant where I only enable features?

If that's easier, please do.

> Should I try the variant where I only enable features? If that's easier, please do.
dpschen commented 2023-02-15 15:28:50 +00:00
Author
Member

Done. Please re-review

Done. Please re-review
dpschen marked this conversation as resolved
frederick commented 2023-02-02 17:08:13 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3051-fix-postcss-preset-env-client-si--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3051-fix-postcss-preset-env-client-si--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed fix-postcss-preset-env-client-side-polyfills from 7364b790ca to 29e306841c 2023-02-15 15:28:31 +00:00 Compare
dpschen requested review from konrad 2023-02-15 15:29:16 +00:00
konrad merged commit d07ad495e2 into main 2023-02-15 15:40:02 +00:00
konrad deleted branch fix-postcss-preset-env-client-side-polyfills 2023-02-15 15:40:02 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3051
No description provided.
Delete Branch "dpschen/frontend:fix-postcss-preset-env-client-side-polyfills"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?