vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: stop revealing elements on hover if hover is not supported #3191

Merged
konrad merged 4 commits from danstewart/vikunja-frontend:danstewart/fix-ios-double-tap into main 2023-03-04 16:13:33 +00:00
Conversation 5 Commits 4 Files Changed 3 +53 -29
danstewart commented 2023-03-03 18:00:37 +00:00
Contributor
Copy Link

Fixes #3162

A little clunky but works fine from my testing.

The only weird thing I've encountered is on mobile picking a list on the side menu doesn't auto collapse, but it's doing that on main so not related to these changes.

Fixes #3162 A little clunky but works fine from my testing. The only weird thing I've encountered is on mobile picking a list on the side menu doesn't auto collapse, but it's doing that on `main` so not related to these changes.
danstewart added 1 commit 2023-03-03 18:00:39 +00:00
continuous-integration/drone/pr Build is passing Details
da7ddbde27 fix: stop revealing elements on hover if hover is not supported 
Fixes #3162
frederick commented 2023-03-03 18:05:40 +00:00
Member
Copy Link

Hi danstewart!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3191-danstewart-fix-ios-double-tap--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi danstewart! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3191-danstewart-fix-ios-double-tap--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2023-03-03 20:02:26 +00:00
src/components/home/navigation.vue
@ -350,2 +350,4 @@
opacity: 1;
}
@media(hover: hover) and (pointer: fine) {
konrad commented 2023-03-03 20:02:26 +00:00
Owner

How is the browser support for this?

How is the browser support for this?
danstewart commented 2023-03-03 21:09:35 +00:00
Author
Contributor

Pretty good:
https://caniuse.com/css-media-interaction

Pretty good: https://caniuse.com/css-media-interaction
konrad commented 2023-03-03 21:16:00 +00:00
Owner

perfect

perfect
konrad marked this conversation as resolved
konrad reviewed 2023-03-03 21:15:44 +00:00
src/components/list/partials/ListCard.vue
@ -162,3 +162,3 @@
.list-card:hover .favorite {
.list-card .favorite {
opacity: 1;
konrad commented 2023-03-03 21:15:44 +00:00
Owner

Aren't all the opacity: 1 statements outside the media queries now redundant?

Aren't all the `opacity: 1` statements outside the media queries now redundant?
👍 1
danstewart commented 2023-03-03 21:30:32 +00:00
Author
Contributor

Good catch, I was duplicating a few rules as I kept the original opacity: 0 then immediately set it back to opacity: 1.

I've removed the duplicates now.

Good catch, I was duplicating a few rules as I kept the original `opacity: 0` then immediately set it back to `opacity: 1`. I've removed the duplicates now.
konrad marked this conversation as resolved
danstewart added 1 commit 2023-03-03 21:29:52 +00:00
continuous-integration/drone/pr Build is passing Details
fe7cbfdc14 fix: reduce duplicate CSS rules
konrad requested changes 2023-03-03 21:38:43 +00:00
konrad left a comment
Owner

Looks like this now hides the favorite icons on desktop:

image

vs on try:

image

Looks like this now hides the favorite icons on desktop: ![image](/attachments/3bb3d8b2-2899-4929-a0c5-10112426e1cf) vs on [try](https://try.vikunja.io): ![image](/attachments/2976eddb-c1cf-4a2a-88a1-6a4e6fe1b285)
image.png
17 KiB
image.png
18 KiB
danstewart commented 2023-03-03 21:57:35 +00:00
Author
Contributor
Copy Link

@konrad Odd, it works fine for me 🤔

Which browser and device are you using? I've tried on Chrome and Firefox.

@konrad Odd, it works fine for me 🤔 Which browser and device are you using? I've tried on Chrome and Firefox.
konrad commented 2023-03-03 22:07:37 +00:00
Owner
Copy Link

Tested in Firefox and Chromium on NixOS. Tested with the review link above.

The favorite icons only show up when hovering, not by default (as they do on try).

Tested in Firefox and Chromium on NixOS. Tested with the review link above. The favorite icons only show up when hovering, not by default (as they do on try).
danstewart added 1 commit 2023-03-03 22:18:28 +00:00
continuous-integration/drone/pr Build is passing Details
a4656b7f90 fix: always show is-favorite items
danstewart commented 2023-03-03 22:23:36 +00:00
Author
Contributor
Copy Link

Sorry, I was being dumb.

Should be sorted now - thank you.

Sorry, I was being dumb. Should be sorted now - thank you.
konrad reviewed 2023-03-04 13:20:24 +00:00
src/components/home/navigation.vue
@ -496,0 +506,4 @@
opacity: 1;
}
.list-menu:hover .favorite {
konrad commented 2023-03-04 13:20:05 +00:00
Owner

Can you unify these two rules to something like

.list-menu:hover .favorite,
.favorite.is-favorite {
	opacity: 1;
}
``
Can you unify these two rules to something like ```css .list-menu:hover .favorite, .favorite.is-favorite { opacity: 1; } ``
danstewart marked this conversation as resolved
src/components/tasks/partials/singleTaskInList.vue
@ -367,3 +363,2 @@
&:hover .handle {
opacity: 1;
@media(hover: hover) and (pointer: fine) {
konrad commented 2023-03-04 13:20:22 +00:00
Owner

same for unifying these rules here as well.

same for unifying these rules here as well.
danstewart marked this conversation as resolved
danstewart added 1 commit 2023-03-04 15:34:46 +00:00
continuous-integration/drone/pr Build is passing Details
79ed7bf6ce fix: combine rules
danstewart requested review from konrad 2023-03-04 15:35:07 +00:00
danstewart commented 2023-03-04 15:35:22 +00:00
Author
Contributor
Copy Link

Addressed those last two comments. 🙂

Addressed those last two comments. 🙂
konrad approved these changes 2023-03-04 16:12:54 +00:00
konrad left a comment
Owner

Thanks!

Thanks!
konrad merged commit 7b6f76d1b4 into main 2023-03-04 16:13:33 +00:00
konrad deleted branch danstewart/fix-ios-double-tap 2023-03-04 16:13:33 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3191
No description provided.
Delete Branch "danstewart/vikunja-frontend:danstewart/fix-ios-double-tap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?