fix: list view: don't sort tasks after marking one "done" #3285
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#3285
Loading…
Reference in New Issue
No description provided.
Delete Branch "WofWca/frontend:disable-list-sort-after-mark-done"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
See https://community.vikunja.io/t/list-view-tasks-being-sorted-after-marking-one-done-throws-you-off/1257/2
Seems legit to me. Can't think of any case where this wouldn't work. In order to test this on a preview the lint needs to pass. @WofWca Could you remove the function definition of
sortTasks()
as well, now that it isn't used anymore?8c7ace7891
tod41143223a
Hi WofWca!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://3285-disable-list-sort-after-mark-don--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
Somehow the pop sound isn't played anymore when you check of the item.
I tried the prev. commit. It's not played there either. Try this preview, for example:
#3278
You are right. The reason why it did play for me was that I changed the language once in https://try.vikunja.io (with which I compared this branch) what triggered the
playSoundWhenDoneKey
to be saved. That's not really optimal. We enable this automatically if you save the settings and none are set yet, because we wanted this as a default, while at the same time we didn't want to annoy users to always save this setting. Because right now no good storage exists for this kind of simple user settings it's saved in local storage…LGTM!