vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Change description edit button style for consistency #3298

Closed
Bouni wants to merge 1 commits from Bouni/vikunja-frontend:edit-button into main
pull from: Bouni/vikunja-frontend:edit-button
merge into: vikunja:main
Conversation 8 Commits 1 Files Changed 1 +6 -3
Bouni commented 2023-03-24 08:32:51 +00:00
Contributor
Copy Link

The edit button for the description of a task is just a text which is hard to identify as a button and not consistent with the save button for example:

grafik

This PR makes the button style consistent with the save button:

grafik

The edit button for the description of a task is just a text which is hard to identify as a button and not consistent with the save button for example: ![grafik](/attachments/39b1d9a2-12c1-47dc-b0aa-9b3bb8a6f25a) This PR makes the button style consistent with the save button: ![grafik](/attachments/9a639e18-a4a0-44f0-9ab0-9c5929084a69)
grafik.png
4.7 KiB
grafik.png
4.8 KiB
👍 1
Bouni added 1 commit 2023-03-24 08:32:52 +00:00
continuous-integration/drone/pr Build is passing Details
217f9a0d7b Change edit button sytle for consitency
Bouni commented 2023-03-24 08:34:20 +00:00
Author
Contributor
Copy Link

I wanted to prepend icons to the edit and the save button, but couldn't figure out where to lookup the right names ...

Maybe on of you guys could point out where to look them up and I'll update the PR accordingly.

I wanted to prepend icons to the edit and the save button, but couldn't figure out where to lookup the right names ... Maybe on of you guys could point out where to look them up and I'll update the PR accordingly.
frederick commented 2023-03-24 08:38:28 +00:00
Member
Copy Link

Hi Bouni!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3298-edit-button--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi Bouni! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3298-edit-button--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen requested review from dpschen 2023-03-24 14:23:09 +00:00
konrad commented 2023-03-24 18:37:12 +00:00
Owner
Copy Link

I'm not sure about this. If we merge this, we probably should also change the edit button for comments, so that it is consistent everywhere. I think it would be a bit "too much", having a big button like that under every comment.

I'm not sure about this. If we merge this, we probably should also change the edit button for comments, so that it is consistent everywhere. I think it would be a bit "too much", having a big button like that under every comment.
👍 1
konrad commented 2023-03-24 18:37:38 +00:00
Owner
Copy Link

The icons are from Font Awesome.

The icons are from Font Awesome.
Bouni commented 2023-03-27 12:06:57 +00:00
Author
Contributor
Copy Link

@konrad I agree with you that such a large button under every comment might be a bit overwhelming. On the other hand the existing edit button under the description is way to small ...

Maybe some sort of "dense" button style for the comment buttons?

The icons are from Font Awesome.

I know, and I tried icon="save" and icon="floppy-disk" and neither worked.

Later I figured out that I need to use :icon="['fas', 'floppy-disk']" 😅

@konrad I agree with you that such a large button under every comment might be a bit overwhelming. On the other hand the existing edit button under the description is way to small ... Maybe some sort of "dense" button style for the comment buttons? > The icons are from Font Awesome. I know, and I tried `icon="save"` and `icon="floppy-disk"` and neither worked. Later I figured out that I need to use `:icon="['fas', 'floppy-disk']"` 😅
👍 1
dpschen commented 2023-03-27 21:09:42 +00:00
Member
Copy Link

I'm not sure about this. If we merge this, we probably should also change the edit button for comments, so that it is consistent everywhere. I think it would be a bit "too much", having a big button like that under every comment.

Agree. There should be a slot in the editor exposing the functionality. I'm still on this task. I have to check some stuff locally. Will get back to this.

> I'm not sure about this. If we merge this, we probably should also change the edit button for comments, so that it is consistent everywhere. I think it would be a bit "too much", having a big button like that under every comment. Agree. There should be a slot in the editor exposing the functionality. I'm still on this task. I have to check some stuff locally. Will get back to this.
dpschen self-assigned this 2023-03-28 09:33:20 +00:00
dpschen changed title from Change description edit button sytle for consitency to Change description edit button style for consistency 2023-04-13 09:29:37 +00:00
konrad commented 2023-10-22 17:08:30 +00:00
Owner
Copy Link

Hey @Bouni are you still interested in this?

Hey @Bouni are you still interested in this?
konrad commented 2024-01-16 12:10:55 +00:00
Owner
Copy Link

Closing due to inactivity. Please ping if you want to pick it up again.

Closing due to inactivity. Please ping if you want to pick it up again.
konrad closed this pull request 2024-01-16 12:10:55 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dpschen
4 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3298
No description provided.
Delete Branch "Bouni/vikunja-frontend:edit-button"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?