Show task progress on task #354

azymondrian · 2020-12-25T03:18:43Z

azymondrian commented

2020-12-25 03:18:43 +00:00

I'm not sure if you guys want this, but I implemented it for myself and figured I'd see.

Shows the task completion percent as progress bar in task lists and on kanban cards.

I'm not sure if you guys want this, but I implemented it for myself and figured I'd see. Shows the task completion percent as progress bar in task lists and on kanban cards.

Screenshot 2020-12-24 211752.png

2.2 KiB

azymondrian commented

2020-12-25 03:42:53 +00:00

The same test is failing locally for me too, have not figured out why...

konrad requested changes 2020-12-28 22:13:31 +00:00

konrad left a comment

Could you put the progress bar next to the other task properties so that everything is in one like? Maybe only on mobile underneath?

konrad commented

2020-12-28 22:16:27 +00:00

The test failure doesn't really make sense - I've restarted the build to see if that "fixes" it.

konrad commented

2020-12-28 22:21:36 +00:00

Looks like the test failing here fails everywhere, just not on master.

konrad commented

2020-12-28 22:44:15 +00:00

Found the issue and fixed it in ddd24825a3

Found the issue and fixed it in https://drone.kolaente.de/link/vikunja/frontend/commit/ddd24825a32a2a646f126212071c4b56fa751131

azymondrian commented

2020-12-28 23:22:57 +00:00

Ah that's a good idea! I'll definitely update that

azymondrian force-pushed show-progress from 083d71cf4f to 210ef19c43

2020-12-29 17:22:10 +00:00

Compare

azymondrian commented

2020-12-29 17:26:34 +00:00

I think this looks good to me, but there's a lot of tweaking that can be done depending on how you want the progress bar to shrink.

azymondrian requested review from konrad 2020-12-29 17:31:42 +00:00

profi248 commented

2020-12-29 21:53:12 +00:00

I tried it out, and it looks nice, but #358 seems to have broken it.
It should work if you change flex: 1 0 xxx to flex: 0 0 xxx on .color-bubble class, in tasks.scss and navigation.scss.

I tried it out, and it looks nice, but #358 seems to have broken it. It should work if you change `flex: 1 0 xxx` to `flex: 0 0 xxx` on `.color-bubble` class, in `tasks.scss` and `navigation.scss`. ![image](/attachments/c7159050-0b0d-480f-9340-de2ab09c6ac5)

image.png

27 KiB

azymondrian commented

2020-12-30 05:12:38 +00:00

Good catch, I hadn't turned on many colors yet. I'll work on that

konrad commented

2020-12-30 16:38:47 +00:00

Looks good so far, I think the progressbar could take up the full width on kanban as it already does that on mobile kanban:

instead of

I'd also make it a bit smaller on the kanban board.

Looks good so far, I think the progressbar could take up the full width on kanban as it already does that on mobile kanban: ![image](/attachments/22cac8c8-c498-46d7-83c6-886652fa5716) instead of ![image](/attachments/6e94a447-9e82-46f5-9cc6-e0269ed90dda) I'd also make it a bit smaller on the kanban board.

image.png

12 KiB

image.png

15 KiB

azymondrian commented

2020-12-30 20:36:49 +00:00

Shoot that's a regression, I forgot to double check how that last commit affected the kanban cards.

How much smaller are you thinking? I think 0.6 rem looks reasonably smaller without looking too small?

Shoot that's a regression, I forgot to double check how that last commit affected the kanban cards. How much smaller are you thinking? I think 0.6 rem looks reasonably smaller without looking too small?

konrad commented

2020-12-30 20:57:52 +00:00

I think .5rem would look good:

It currently is at .75rem

I think `.5rem` would look good: ![image](/attachments/0018281d-4633-4399-a286-618b4fa0dad1) It currently is at `.75rem`

image.png

11 KiB

azymondrian force-pushed show-progress from 210ef19c43 to b03fbdd297

2020-12-31 00:59:06 +00:00

Compare

azymondrian commented

2020-12-31 01:00:51 +00:00