Replace vue-multiselect with a custom component #366

Merged

konrad merged 46 commits from feature/multiselect into master 2021-01-06 22:36:32 +00:00

Conversation 0 Commits 46 Files Changed 26 +986 -1022

konrad commented 2021-01-02 21:08:13 +00:00

Owner

Copy Link

This PR replaces vue-multiselect with a custom made component for a smaller dependency footprint and better matching of the "look and feel" of the rest of Vikunja.

TODO

• Select the first element when pressing enter and only one element was found
• Fix all tests
• Add test for adding a user to a team
• Add test for managing labels on a task
• Add test for managing assignees on a task
• Make sure it looks good on mobile

This PR replaces `vue-multiselect` with a custom made component for a smaller dependency footprint and better matching of the "look and feel" of the rest of Vikunja. ### TODO * [x] Select the first element when pressing enter and only one element was found * [x] Fix all tests * [x] Add test for adding a user to a team * [x] Add test for managing labels on a task * [x] Add test for managing assignees on a task * [x] Make sure it looks good on mobile

konrad added 36 commits 2021-01-02 21:08:14 +00:00

Add very basic searchable select 75590109ad

Make selection through arrow keys work e5facd4c83

Make it look good 68d3844aee

Make the search results float above everything else 1cce20c60f

Start adding a focus group c7e347dd90

Fix focus styles 0472328824

Add logic for the loading spinner 9de949e88d

Add logic to hide the search results when clicking outside of the multiselect 3266d51981

Fix default and hover states 55c586e8ae

Make sure v-model is used and populated correctly 38638d999f

Add creatable functionality c7fa9bc3cc

Fix tasks not available 31df088641

Add create on enter in search input 7b05558f2f

Disable create when there is an exact match in the search results 6448591f72

Cleanup a4b5182d58

Add report command to yarn scripts 6aa66b9878

Make the select placeholder configurable 2d670b203f

Move the list search component to the new multiselect dcf8d5e4d1

Fix placeholder font style 643cd75496

Fix hiding search results after selecting a value 2990bff919

Add a slot for search results 5f7039e101

Move namespace search to new multiselect 9644e43474

Fix select height in field with addons 0c7fc99246

Move user/team sharing to new multiselect 9b0d4e93dc

Migrate team member search to new multiselect 1025c3a26d

Add multiselect capabilities 78fd335232

Fix breakpoint layout d974de5b2e

Migrate assignee filter to new multiselect fe651ccc14

Migrate label filter to new multiselect 450fa583bb

Migrate list & namespaces filter to new multiselect b7c6e58222

Migrate task assignee to new multiselect e00038c32f

Adjust styling for assignee editing 4927f4a554

Migrate label edit to new multiselect 138c780d4d

Cleanup 1c9a3359bd

Fix multiselect tests 9620ed43fe

Fix multiselect tests 05e4bba6f7

konrad added 1 commit 2021-01-04 21:30:11 +00:00

Fix saving a team 05978e2b5f

konrad added 1 commit 2021-01-04 21:50:59 +00:00

Add selecting single search result on enter 5042d1ca91

konrad added 1 commit 2021-01-04 21:51:06 +00:00

Merge branch 'master' into feature/multiselect 44068e99cc

konrad added 1 commit 2021-01-04 22:04:15 +00:00

Add test for adding a user to a team eaa36d7f37

konrad added 1 commit 2021-01-04 22:20:40 +00:00

Merge branch 'master' into feature/multiselect cb64aebd92

konrad added 1 commit 2021-01-06 17:45:26 +00:00

Merge branch 'master' into feature/multiselect 17ab80e913

konrad added 1 commit 2021-01-06 18:05:15 +00:00

Add tests for managing assignees on a task 4fac2b4750

konrad added 1 commit 2021-01-06 18:20:33 +00:00

Add tests for managing labels on a task cf7136769d

konrad added 1 commit 2021-01-06 18:20:47 +00:00

Remove .only modifier 10885f673c

konrad added 1 commit 2021-01-06 18:37:39 +00:00

Fix mobile versions of the dropdown with search results 84e6dd93e4

konrad merged commit fe6d975134 into master 2021-01-06 22:36:32 +00:00

konrad referenced this issue from a commit 2021-01-06 22:36:32 +00:00

Replace vue-multiselect with a custom component (#366)

konrad deleted branch feature/multiselect 2021-01-06 22:36:39 +00:00

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

Labels

Clear labels   

area/internal-code

  

changes requested

  

confirmed

  

dependencies

  

duplicate

This issue or pull request already exists

  

good first issue

  

help wanted

Need some help

  

hosting

  

invalid

Something is wrong

  

kind/bug

Something is not working

  

kind/feature

New feature

  

question

More information is needed

  

wontfix

This won't be fixed

No Label

area/internal-code

changes requested

confirmed

dependencies

duplicate

good first issue

help wanted

hosting

invalid

kind/bug

kind/feature

question

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#366

No description provided.