feat: reduce file size by removing by removing fonts #759
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#759
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/reduce-file-size-by-removing-font-weights"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The fonts were either not used at all (300)
or used so rarely that it makes sense to replace them by other weights (500).The navigation still looks good.For the future it might make sense to use variable fonts instead. Then the 500 weight could be used again without a size impact.
Both fonts do exist in a variable editon:
EDIT: See #778
I'm not quite conviced. What's bothering me is that the font weight is not the same for menu items and lists/filters:
And it looks like the font used for list in the menu is not Open Sans anymore but some random font from my system? That might be an issue with the bulma variables though.EDIT: Yup, bulma issue. Updated the branch and it looks fine, nevermind the noise.Okay :) Not sure what I should change then.
This is still an issue - the bulma thing was about using a different font being used in the lists.
Okay. Maybe let's remove just the 300 for now (can't find any reference) and keep the 500. I agree that it looks better. I think I was just overoptimizing here :D
I will open a (not very important but interesting) issue for the variable fonts.
5757c111b7
to631ad0b446
631ad0b446
to89fd09aa92
@konrad not sure why the pipeline fails.
Now I'm just removing that one font file and it's import.
Restarted the build, seems to pass now.