vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: implement modals with vue router 4 #816

Merged
konrad merged 62 commits from dpschen/frontend:feature/vue3-modals-with-router-4 into main 2022-02-05 16:49:04 +00:00
Conversation 39 Commits 62 Files Changed 62 +6 -3
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4fc9384acc - Show all commits

6
.drone.yml
View File

@ -116,10 +116,12 @@ steps:
YARN_CACHE_FOLDER: .cache/yarn/
CYPRESS_CACHE_FOLDER: .cache/cypress/
CYPRESS_DEFAULT_COMMAND_TIMEOUT: 60000
CYPRESS_RECORD_KEY:
from_secret: cypress_project_key
commands:
- sed -i 's/localhost/api/g' dist/index.html
- yarn serve:dist & npx wait-on http://localhost:5000
- yarn test:frontend --browser chrome
- yarn test:frontend --browser chrome --record
depends_on:
- dependencies
- build-prod
@ -665,6 +667,6 @@ steps:
from_secret: crowdin_key
---
kind: signature
hmac: 188ee90100c5fc5922a445e531e7a47453121edddb2a64a182eb23ed2bf602de
hmac: e8748058b09d57b4d9f53dc40fb163f1719a4177d392439a62b1c198ba1502a0
...

3
cypress.json
View File

@ -7,5 +7,6 @@
"video": false,
"retries": {
"runMode": 2
}
},
"projectId": "181c7x"
}
dpschen marked this conversation as resolved Outdated
konrad commented 2021-12-04 15:03:53 +00:00
Outdated
Review
Copy Link

Why is the list.spec.js seperated from the rest?

Why is the `list.spec.js` seperated from the rest?
dpschen commented 2021-12-04 15:24:44 +00:00
Outdated
Review
Copy Link

Because I splitted the test from the different views list.spec.js was not the first test but the last after the views (because it's imported by abc order).
With this the tests in the file stay at the beginning.
Maybe better to prefix with numbers to maintain the order? Or just an understore for the general list tests to force the correct order?

Because I splitted the test from the different views list.spec.js was not the first test but the last after the views (because it's imported by abc order). With this the tests in the file stay at the beginning. Maybe better to prefix with numbers to maintain the order? Or just an understore for the general list tests to force the correct order?
konrad commented 2021-12-04 15:27:23 +00:00
Outdated
Review
Copy Link

The order of the tests should not matter. Each test should work the same whether it was executed with all other ones in one run or individually.
I think we can ignore the acutal order in which the tests are executed.

The order of the tests should not matter. Each test should work the same whether it was executed with all other ones in one run or individually. I think we can ignore the acutal order in which the tests are executed.
dpschen commented 2021-12-04 16:06:01 +00:00
Outdated
Review
Copy Link

Done. Checking if the tests run through.
they should, but I remember that I had some problems, maybe that's solved)

Done. Checking if the tests run through. they should, but I remember that I had some problems, maybe that's solved)
konrad commented 2021-12-04 16:26:10 +00:00
Outdated
Review
Copy Link

Looks like there's a syntax error in the cypress config file now: https://drone.kolaente.de/vikunja/frontend/5026/1/7

Looks like there's a syntax error in the cypress config file now: https://drone.kolaente.de/vikunja/frontend/5026/1/7
👍 1
dpschen commented 2021-12-04 16:35:50 +00:00
Outdated
Review
Copy Link

Sometimes it's really cool, if you know JSON #fail
(was a line end comma)

Sometimes it's really cool, if you know JSON #fail (was a line end comma)
😆 1