vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: implement modals with vue router 4 #816

Merged
konrad merged 62 commits from dpschen/frontend:feature/vue3-modals-with-router-4 into main 2022-02-05 16:49:04 +00:00
Conversation 39 Commits 62 Files Changed 62 +4 -4
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5867f79735 - Show all commits

4
src/components/tasks/partials/comments.vue
View File

@ -152,7 +152,7 @@
</template>
<script>
import Editor from '@/components/input/editor.vue'
import AsyncEditor from '@/components/input/AsyncEditor'
import TaskCommentService from '../../../services/taskComment'
import TaskCommentModel from '../../../models/taskComment'
@ -162,7 +162,7 @@ import {mapState} from 'vuex'
export default {
name: 'comments',
components: {
Editor,
Editor: AsyncEditor,
},
props: {
taskId: {

4
src/components/tasks/partials/description.vue
View File

@ -30,7 +30,7 @@
</template>
<script>
import Editor from '@/components/input/editor.vue'
import AsyncEditor from '@/components/input/AsyncEditor'
import {LOADING} from '@/store/mutation-types'
import {mapState} from 'vuex'
@ -38,7 +38,7 @@ import {mapState} from 'vuex'
export default {
name: 'description',
components: {
Editor,
Editor: AsyncEditor,
dpschen marked this conversation as resolved Outdated
konrad commented 2022-01-08 12:06:36 +00:00
Outdated
Review
Copy Link

Why do you want to load the editor directly instead of async? Are you loading the whole task component async?

Why do you want to load the editor directly instead of async? Are you loading the whole task component async?
dpschen commented 2022-01-19 22:25:59 +00:00
Outdated
Review
Copy Link

I was probably going to far here – will undo.

I guess loading the editor async might even make sense with a new smaller package.

I was probably going to far here – will undo. I guess loading the editor async might even make sense with a new smaller package.
👍 1
},
data() {
return {