vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: implement modals with vue router 4 #816

Merged
konrad merged 62 commits from dpschen/frontend:feature/vue3-modals-with-router-4 into main 2022-02-05 16:49:04 +00:00
Conversation 39 Commits 62 Files Changed 62 +6 -1
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e837621ef8 - Show all commits

7
src/components/home/contentAuth.vue
View File

@ -20,7 +20,12 @@
<quick-actions/>
<router-view :route="routeWithModal"/>
<router-view :route="routeWithModal" v-slot="{ Component }">
<keep-alive :include="['list.list', 'list.gantt', 'list.table', 'list.kanban']">
dpschen marked this conversation as resolved Outdated
konrad commented 2021-10-03 18:50:34 +00:00
Outdated
Review
Copy Link

I don't think it is, we should make sure the modal views keep their transition though. Might make sense to include that in the modal component itself?

I don't think it is, we should make sure the modal views keep their transition though. Might make sense to include that in the modal component itself?
👍 1
dpschen commented 2021-10-11 10:46:34 +00:00
Outdated
Review
Copy Link

Either that or put the transition inside something like a provider component. In that we could use the new teleport component. I was always using portal-vue in vue 2 for this kind of stuff.

Either that or put the transition inside something like a provider component. In that we could use the [new teleport component](https://v3.vuejs.org/api/built-in-components.html#teleport). I was always using [portal-vue](https://github.com/LinusBorg/portal-vue) in vue 2 for this kind of stuff.
konrad commented 2021-10-11 18:42:35 +00:00
Outdated
Review
Copy Link

I think using the teleport component allows for a cleaner solution since there are situations where you want a transition handled by the route and others where you want to have it handled by the outer component (like delete modals).

I think using the teleport component allows for a cleaner solution since there are situations where you want a transition handled by the route and others where you want to have it handled by the outer component (like delete modals).
👍 1
<component :is="Component" />
</keep-alive>
</router-view>
<transition name="modal">
<component v-if="currentModal" :is="currentModal" />