vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/use-setup-api-for-user-and-about-pages #929

Merged
konrad merged 1 commits from dpschen/frontend:feature/use-setup-api-for-user-and-about-pages into main 2021-11-14 20:57:37 +00:00
Conversation 1 Commits 1 Files Changed 9 +167 -202
dpschen commented 2021-11-01 10:21:11 +00:00
Member
Copy Link
No description provided.
dpschen added the
kind/feature
 label 2021-11-01 10:21:11 +00:00
konrad was assigned by dpschen 2021-11-01 10:21:11 +00:00
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from 991141b7de to 3bf7867be5 2021-11-01 10:52:01 +00:00 Compare
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from 3bf7867be5 to b5d6595509 2021-11-01 10:53:09 +00:00 Compare
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from b5d6595509 to 4877689216 2021-11-01 11:00:42 +00:00 Compare
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from 4877689216 to c65eccc3cb 2021-11-01 11:01:58 +00:00 Compare
dpschen changed title from feature/use-setup-api-for-user-and-about-pages to WIP: feature/use-setup-api-for-user-and-about-pages 2021-11-01 13:22:56 +00:00
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from c65eccc3cb to 7b0657eacd 2021-11-01 15:34:32 +00:00 Compare
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from 7b0657eacd to f680995481 2021-11-01 16:16:18 +00:00 Compare
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from f680995481 to 507efbf17b 2021-11-01 16:17:13 +00:00 Compare
konrad was unassigned by dpschen 2021-11-01 16:46:48 +00:00
dpschen self-assigned this 2021-11-01 16:46:53 +00:00
dpschen reviewed 2021-11-01 16:48:07 +00:00
src/views/user/Register.vue Outdated
@ -117,3 +104,1 @@
}
},
beforeMount() {
beforeRouteEnter() {
dpschen commented 2021-11-01 16:48:07 +00:00
Author
Member

Damn. I need some stuff from the auth branch. Will continue to work there.
This is a suboptimal solution either way…

Damn. I need some stuff from the auth branch. Will continue to work there. This is a suboptimal solution either way…
dpschen commented 2021-11-14 13:50:51 +00:00
Author
Member

Solved with temporary solution.
Using onBeforeMount so exactly as good as solution before.

Solved with temporary solution. Using `onBeforeMount` so exactly as good as solution before.
dpschen marked this conversation as resolved
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from 507efbf17b to 505fa1045d 2021-11-02 20:47:49 +00:00 Compare
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from 505fa1045d to 7d322f925a 2021-11-14 13:32:01 +00:00 Compare
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from 7d322f925a to 95186a94c9 2021-11-14 13:40:18 +00:00 Compare
frederick commented 2021-11-14 13:43:54 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://929-featureuse-setup-api-for-user-and-about-pages--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://929-featureuse-setup-api-for-user-and-about-pages--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from WIP: feature/use-setup-api-for-user-and-about-pages to feature/use-setup-api-for-user-and-about-pages 2021-11-14 13:50:59 +00:00
dpschen requested review from konrad 2021-11-14 13:51:06 +00:00
konrad was assigned by dpschen 2021-11-14 13:51:14 +00:00
dpschen removed their assignment 2021-11-14 13:51:14 +00:00
konrad reviewed 2021-11-14 16:09:41 +00:00
cypress/integration/user/registration.spec.js Outdated
@ -27,2 +27,2 @@
cy.get('#password1').type(fixture.password)
cy.get('#password2').type(fixture.password)
cy.get('#password').type(fixture.password)
cy.get('#passwordValidation').type(fixture.password)
konrad commented 2021-11-14 16:04:19 +00:00
Owner

That's a lot better!

That's a lot better!
konrad marked this conversation as resolved
src/helpers/setTitle.js Outdated
@ -6,2 +1,2 @@
document.title = `${title} | Vikunja`
export function setTitle(title) {
document.title = typeof title === 'undefined' || title === ''
konrad commented 2021-11-14 16:05:23 +00:00
Owner

Shouldn't this be

document.title = (typeof title === 'undefined' || title === '')

(with braces)?

Shouldn't this be ``` document.title = (typeof title === 'undefined' || title === '') ``` (with braces)?
👍 1
dpschen commented 2021-11-14 16:50:07 +00:00
Author
Member

Shall I revert then? My changes don't make it much better then

Shall I revert then? My changes don't make it much better then
konrad commented 2021-11-14 16:50:46 +00:00
Owner

I think that would work.

I think that would work.
dpschen marked this conversation as resolved
src/views/user/RequestPasswordReset.vue Outdated
@ -82,0 +61,4 @@
const { t } = useI18n()
useTitle(() => t('user.auth.resetPassword'))
// Not sure if this instance needs a shalloRef at all
konrad commented 2021-11-14 16:09:29 +00:00
Owner

There's the loading state on the submit button. Doesn't that require a shallowRef?

There's the loading state on the submit button. Doesn't that require a shallowRef?
dpschen commented 2021-11-14 16:46:06 +00:00
Author
Member

Yeah what I meant is that I was not sure if a ref or reactive makes more sense.
In cases of "libs" I'm still not always sure what makes most sense.

Yeah what I meant is that I was not sure if a ref or reactive makes more sense. In cases of "libs" I'm still not always sure what makes most sense.
dpschen commented 2021-11-14 16:48:08 +00:00
Author
Member

Now that I think of it: It might be better a reactive. (Ref would also be fine but reactive seems nicer to use in the case).

Now that I think of it: It might be better a reactive. (Ref would also be fine but reactive seems nicer to use in the case).
👍 1
dpschen marked this conversation as resolved
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from 95186a94c9 to 4601b8a3a2 2021-11-14 17:07:26 +00:00 Compare
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from 4601b8a3a2 to aa43ead3a8 2021-11-14 17:08:26 +00:00 Compare
dpschen force-pushed feature/use-setup-api-for-user-and-about-pages from aa43ead3a8 to 237e510774 2021-11-14 19:13:15 +00:00 Compare
konrad approved these changes 2021-11-14 20:57:27 +00:00
konrad merged commit d0d4096f8b into main 2021-11-14 20:57:37 +00:00
konrad deleted branch feature/use-setup-api-for-user-and-about-pages 2021-11-14 20:57:37 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#929
No description provided.
Delete Branch "dpschen/frontend:feature/use-setup-api-for-user-and-about-pages"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?