vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

chore: don't spread arguments #933

Merged
konrad merged 1 commits from dpschen/frontend:feature/fix-auth-arguments into main 2021-11-02 18:17:26 +00:00
Conversation 0 Commits 1 Files Changed 1 +2 -5
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/store/modules/auth.js
View File

@ -120,12 +120,9 @@ export default {
// Not sure if this is the right place to put the logic in, maybe a seperate js component would be better suited.
async register(ctx, credentials) {
const HTTP = HTTPFactory()
ctx.commit(LOADING, true, {root: true})
dpschen commented 2021-11-01 18:58:45 +00:00
Review
Copy Link

Was not sure here, but seems to have been missing.

Was not sure here, but seems to have been missing.
konrad commented 2021-11-02 18:12:34 +00:00
Review
Copy Link

Good catch!

Good catch!
konrad commented 2021-11-02 18:14:33 +00:00
Review
Copy Link

Though I just noticed that's already being set in the register component (which is bad). Could you remove it there? Not nessecarily here in this PR, another one is fine.

Though I just noticed that's already being set [in the register component](https://kolaente.dev/vikunja/frontend/src/branch/main/src/views/user/Register.vue#L134) (which is bad). Could you remove it there? Not nessecarily here in this PR, another one is fine.
konrad commented 2021-11-02 18:17:10 +00:00
Review
Copy Link

Created a follow-up: #939

Created a follow-up: https://kolaente.dev/vikunja/frontend/pulls/939
try {
await HTTP.post('register', {
username: credentials.username,
email: credentials.email,
password: credentials.password,
})
await HTTP.post('register', credentials)
return ctx.dispatch('login', credentials)
} catch(e) {
if (e.response?.data?.message) {