vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: harden textarea auto height algorithm #985

Merged
konrad merged 1 commits from dpschen/frontend:feature/harden-textarea-auto-height into main 2021-11-30 20:20:41 +00:00
Conversation 13 Commits 1 Files Changed 2 +148 -98
dpschen commented 2021-11-12 16:26:25 +00:00
Member
Copy Link

tested on current chrome, firefox, safari

tested on current chrome, firefox, safari
konrad was assigned by dpschen 2021-11-12 16:26:25 +00:00
frederick commented 2021-11-12 16:29:41 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://985-featureharden-textarea-auto-height--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://985-featureharden-textarea-auto-height--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from feat: harden textarea auto height algorythm to feat: harden textarea auto height algorithm 2021-11-12 17:29:54 +00:00
konrad approved these changes 2021-11-13 13:58:54 +00:00
konrad left a comment
Owner

It looks like this breaks on Firefox mobile (android).

It looks like this breaks on Firefox mobile (android).
Screenshot_20211113-145630__01.jpg
32 KiB
Screenshot_20211113-145630__01.jpg
konrad requested changes 2021-11-13 13:59:28 +00:00
konrad left a comment
Owner

Whoops, didn't mean to approve

Whoops, didn't mean to approve
dpschen was assigned by konrad 2021-11-13 14:00:53 +00:00
konrad removed their assignment 2021-11-13 14:00:56 +00:00
dpschen commented 2021-11-13 14:06:13 +00:00
Author
Member
Copy Link

Seems like 'harden' was the wrong term :P
Will check

Seems like 'harden' was the wrong term :P Will check
dpschen force-pushed feature/harden-textarea-auto-height from 7b336d1fda to b8df6f2fb7 2021-11-17 14:11:53 +00:00 Compare
dpschen reviewed 2021-11-17 14:12:38 +00:00
src/components/tasks/add-task.vue Outdated
@ -7,3 +7,3 @@
class="input"
:placeholder="$t('list.list.addPlaceholder')"
cols="1"
rows="1"
dpschen commented 2021-11-17 14:12:38 +00:00
Author
Member

Maybe this line fixes the issues in android.

cols="1" was wrong either way :D

Maybe this line fixes the issues in android. `cols="1"` was wrong either way :D
dpschen marked this conversation as resolved
konrad commented 2021-11-17 19:25:46 +00:00
Owner
Copy Link

Still broken :/ this time on firefox desktop (v89.0) as well.

Still broken :/ this time on firefox desktop (v89.0) as well.
dpschen commented 2021-11-17 19:26:23 +00:00
Author
Member
Copy Link

Still broken :/ this time on firefox desktop (v89.0) as well.

:/

> Still broken :/ this time on firefox desktop (v89.0) as well. :/
konrad force-pushed feature/harden-textarea-auto-height from f150bd732f to a6234a5806 2021-11-17 19:26:57 +00:00 Compare
konrad commented 2021-11-17 19:27:48 +00:00
Owner
Copy Link

Also it looks like I completely messed up the git log of this branch when I merged main into it. Should be fine now with a rebase...

Also it looks like I completely messed up the git log of this branch when I merged main into it. Should be fine now with a rebase...
👍 1
dpschen force-pushed feature/harden-textarea-auto-height from a6234a5806 to b8df6f2fb7 2021-11-26 14:12:10 +00:00 Compare
konrad commented 2021-11-26 20:45:45 +00:00
Owner
Copy Link

Still broken in Firefox.

Still broken in Firefox.
dpschen commented 2021-11-26 20:57:52 +00:00
Author
Member
Copy Link

Yes, sry I'm still on this. I just wanted a deployment so that I can test it better =)

Yes, sry I'm still on this. I just wanted a deployment so that I can test it better =)
konrad commented 2021-11-26 21:02:08 +00:00
Owner
Copy Link

Ah makes sense. Looks like I was too enthusiastic with wanting to re-review it.

Just ping me if you're ready :)

Ah makes sense. Looks like I was too enthusiastic with wanting to re-review it. Just ping me if you're ready :)
👍 1 😆 1
dpschen force-pushed feature/harden-textarea-auto-height from b8df6f2fb7 to 8850ac9bf5 2021-11-26 22:04:15 +00:00 Compare
dpschen commented 2021-11-27 13:17:03 +00:00
Author
Member
Copy Link

Ah makes sense. Looks like I was too enthusiastic with wanting to re-review it.

Just ping me if you're ready :)

You can retry, but I didn't test. How can I force a redeploy from @frederick ?

> Ah makes sense. Looks like I was too enthusiastic with wanting to re-review it. > > Just ping me if you're ready :) You can retry, but I didn't test. How can I force a redeploy from @frederick ?
konrad commented 2021-11-28 11:43:25 +00:00
Owner
Copy Link

Seems to work now!

There just one small issue I have with it: After adding a bunch of tasks the input stays the same height:

image

How can I force a redeploy from @frederick ?

It should do one automatically. Looks like it didn't, I've restarted the build pipeline. Maybe that will do.

Seems to work now! There just one small issue I have with it: After adding a bunch of tasks the input stays the same height: ![image](/attachments/d959b913-b62b-4b69-9c5a-9bc2a193cace) > How can I force a redeploy from @frederick ? It should do one automatically. Looks like it didn't, I've restarted the build pipeline. Maybe that will do.
image.png
43 KiB
👍 1 😆 1
dpschen commented 2021-11-28 12:50:50 +00:00
Author
Member
Copy Link

This pull request is starting to get in my top 10 list of most complex pull requests for most meaningless feature :D

(To be clear that's more self critic than critic in the review style. I really like the latter =) )

This pull request is starting to get in my top 10 list of most complex pull requests for most meaningless feature :D (To be clear that's more self critic than critic in the review style. I really like the latter =) )
😆 1
dpschen force-pushed feature/harden-textarea-auto-height from 8850ac9bf5 to 082aba042b 2021-11-29 21:49:58 +00:00 Compare
dpschen requested review from konrad 2021-11-30 13:02:46 +00:00
dpschen commented 2021-11-30 13:04:22 +00:00
Author
Member
Copy Link

I hope this fixes it.
Interesting: I didn't know but there is no way except manual pulling (via setTimout) to check for changes of a textareas value.

The issue that you showed above come from setting the value manually (via vue's bindings).

While I was it I ported the component to typescript and script setup.

I hope this fixes it. Interesting: I didn't know but there is no way except manual pulling (via setTimout) to check for changes of a textareas value. The issue that you showed above come from setting the value manually (via vue's bindings). While I was it I ported the component to typescript and script setup.
dpschen force-pushed feature/harden-textarea-auto-height from 082aba042b to ed9a29dfc9 2021-11-30 17:02:38 +00:00 Compare
konrad approved these changes 2021-11-30 20:20:17 +00:00
konrad left a comment
Owner

Really nice!

Really nice!
konrad merged commit 84284a6211 into main 2021-11-30 20:20:41 +00:00
konrad deleted branch feature/harden-textarea-auto-height 2021-11-30 20:20:41 +00:00
konrad commented 2021-11-30 20:21:16 +00:00
Owner
Copy Link

This pull request is starting to get in my top 10 list of most complex pull requests for most meaningless feature :D

It's beautiful 😁

> This pull request is starting to get in my top 10 list of most complex pull requests for most meaningless feature :D It's beautiful 😁
😆 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dpschen
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#985
No description provided.
Delete Branch "dpschen/frontend:feature/harden-textarea-auto-height"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?