vikunja
/
vikunja
6
43
Fork 71
Code Issues 150 Pull Requests 16 Packages Releases 32 Activity

chore: remove reminderDates after frontend is migrated to reminders #1448

Merged
konrad merged 1 commits from ce72/api:remove_reminderDates into main 2023-06-10 17:21:37 +00:00
Conversation 1 Commits 1 Files Changed 5 +24 -94
ce72 commented 2023-03-28 05:29:32 +00:00
Contributor
Copy Link
No description provided.
ce72 added 1 commit 2023-03-28 05:29:33 +00:00
continuous-integration/drone/pr Build is passing Details
6abd212c57 fix(caldav): Do not create label if it exists by title 
Resolves vikunja/api#1435
ce72 changed title from chore: remove reminderDates after frontend is migrated to reminders to WIP: chore: remove reminderDates after frontend is migrated to reminders 2023-03-28 05:30:24 +00:00
ce72 force-pushed remove_reminderDates from 352926c3af to ca31015245 2023-03-28 05:33:20 +00:00 Compare
ce72 force-pushed remove_reminderDates from ca31015245 to 67f30da7f9 2023-04-01 13:15:18 +00:00 Compare
konrad commented 2023-05-02 14:41:14 +00:00
Owner
Copy Link

I noticed reminders don't repeat when updating a repeating task with reminders because the frontend sends the reminder dates. Let's get this merged as quickly as possible so that's no longer a problem.

Related frontend PR: vikunja/frontend#3248

I noticed reminders don't repeat when updating a repeating task with reminders because the frontend sends the reminder dates. Let's get this merged as quickly as possible so that's no longer a problem. Related frontend PR: https://kolaente.dev/vikunja/frontend/pulls/3248
konrad changed title from WIP: chore: remove reminderDates after frontend is migrated to reminders to chore: remove reminderDates after frontend is migrated to reminders 2023-06-10 17:05:39 +00:00
konrad force-pushed remove_reminderDates from 67f30da7f9 to e001eb07f7 2023-06-10 17:07:00 +00:00 Compare
konrad approved these changes 2023-06-10 17:08:43 +00:00
konrad scheduled this pull request to auto merge when all checks succeed 2023-06-10 17:08:55 +00:00
konrad merged commit 4a4ba041e0 into main 2023-06-10 17:21:37 +00:00
konrad deleted branch remove_reminderDates 2023-06-10 17:25:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
konrad
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1448
No description provided.
Delete Branch "ce72/api:remove_reminderDates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?