fix(dark mode): dark mode adjustments #1069
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
4 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#1069
Loading…
Reference in New Issue
No description provided.
Delete Branch "fix/dark-mode"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Partly resolves #1063
Ping @dpschen @adrinux
@ -77,3 +77,3 @@
--logo-text-color: hsl(180, 1%, 15%);
--link: var(--primary);
I've noticed that variable was not defined so I figured I might just set it. Even if it should probably be set by bulma directly?
Yes, noticed that too. It should be. It's in the Bulma CSS, but I'm not clear how it's set in Bulma Sass - maybe a bug in Bulma-css-variables sass?
Looks like it. Maybe a case for #1064?
We probably want to change it to primary anyway, instead of bulma default blue, so that's all good. But that fact it's not picking it up from bulma is wrong.
Maybe. I'll take a stab at #1064.
Hi konrad!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://1069-fixdark-mode--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
See my comment #1063 (comment)
I think something basic isn't right - though not sure if that's causing these issues or these are edge cases. Possibly a mix of both.