vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix(dark mode): dark mode adjustments #1069

Merged
konrad merged 3 commits from fix/dark-mode into main 2021-11-23 21:20:51 +00:00
Conversation 3 Commits 3 Files Changed 2 +5 -1
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/quick-actions/quick-actions.vue
View File

@ -507,6 +507,8 @@ export default {
.active-cmd {
font-size: 1.25rem;
margin-left: .5rem;
background-color: var(--grey-100);
color: var(--grey-800);
}
}

4
src/styles/custom-properties/colors.scss
View File

@ -76,7 +76,9 @@
--card-border-color: var(--grey-200);
--logo-text-color: hsl(180, 1%, 15%);
--link: var(--primary);
konrad commented 2021-11-23 20:58:48 +00:00
Review
Copy Link

I've noticed that variable was not defined so I figured I might just set it. Even if it should probably be set by bulma directly?

I've noticed that variable was not defined so I figured I might just set it. Even if it should probably be set by bulma directly?
adrinux commented 2021-11-23 21:06:02 +00:00
Review
Copy Link

Yes, noticed that too. It should be. It's in the Bulma CSS, but I'm not clear how it's set in Bulma Sass - maybe a bug in Bulma-css-variables sass?

Yes, noticed that too. It should be. It's in the Bulma CSS, but I'm not clear how it's set in Bulma Sass - maybe a bug in Bulma-css-variables sass?
konrad commented 2021-11-23 21:06:50 +00:00
Review
Copy Link

Looks like it. Maybe a case for #1064?

Looks like it. Maybe a case for #1064?
adrinux commented 2021-11-23 21:08:21 +00:00
Review
Copy Link

We probably want to change it to primary anyway, instead of bulma default blue, so that's all good. But that fact it's not picking it up from bulma is wrong.

We probably want to change it to primary anyway, instead of bulma default blue, so that's all good. But that fact it's not picking it up from bulma is wrong.
adrinux commented 2021-11-23 21:10:50 +00:00
Review
Copy Link

Looks like it. Maybe a case for #1064?

Maybe. I'll take a stab at #1064.

> Looks like it. Maybe a case for #1064? Maybe. I'll take a stab at #1064.
--link-hover: hsla(var(--primary-h), var(--primary-s), var(--primary-l), .75);
--border: var(--grey-200);
&.dark {
// Light mode colours reversed for dark mode