feat: namespaces store with composition api #2607

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2607-feature-feat-pinia-composition-n--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad reviewed 2022-10-31 20:34:16 +00:00

src/stores/namespaces.ts

						
				@ -130,0 +40,4 @@

						return namespaces.value.find(({id}) => id == namespaceId) || null

					})

					const searchNamespace = computed(() => {

konrad commented

2022-10-31 20:33:42 +00:00

Shouldn't this be a function instead of a computed?

dpschen commented

2022-10-31 20:39:13 +00:00

Probably. I was not 100% sure while converting.

I just wanted to do a dumb conversion here, meaning getters will be computeds. Since I wanted this pull request as simple as possible I just continued with this logic.

We can do – and should – these kind of optimizations later.

Probably. I was not 100% sure while converting. I just wanted to do a dumb conversion here, meaning getters will be computeds. Since I wanted this pull request as simple as possible I just continued with this logic. We can do – and should – these kind of optimizations later.

👍 1